Skip to content

[PWGLF] Add min. and max. rapidity cuts - #17382

Merged
romainschotter merged 1 commit into
masterfrom
romainschotter-patch-2
Aug 8, 2026
Merged

[PWGLF] Add min. and max. rapidity cuts#17382
romainschotter merged 1 commit into
masterfrom
romainschotter-patch-2

Conversation

@romainschotter

Copy link
Copy Markdown
Collaborator

Add minimum and maximum rapidity cuts

@github-actions github-actions Bot added the pwglf label Aug 8, 2026
@github-actions github-actions Bot changed the title Add min. and max. rapidity cuts [PWGLF] Add min. and max. rapidity cuts Aug 8, 2026
@github-actions

github-actions Bot commented Aug 8, 2026

Copy link
Copy Markdown

O2 linter results: ❌ 40 errors, ⚠️ 1 warnings, 🔕 0 disabled

@romainschotter
romainschotter marked this pull request as ready for review August 8, 2026 14:35
@romainschotter
romainschotter enabled auto-merge (squash) August 8, 2026 14:35

@alibuild alibuild left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approving on behalf of @romainschotter.

@alibuild

alibuild commented Aug 8, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for 8e92e09 at 2026-08-08 17:07:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'Found 17 errors and 143 warnings.'
Found 17 errors and 143 warnings.
++ [[ 17 -gt 0 ]]
++ cat /sw/BUILD/b48fe319e5a646cba02fea761b0ecd4b9e118204/O2Physics-code-check/errors.txt
PWGLF/Tasks/Strangeness/derivedlambdakzeroanalysis.cxx:90:9: error: function-like macro 'BITSET' used; consider a 'constexpr' template function [cppcoreguidelines-macro-usage,-warnings-as-errors]
PWGLF/Tasks/Strangeness/derivedlambdakzeroanalysis.cxx:91:9: error: function-like macro 'BITCHECK' used; consider a 'constexpr' template function [cppcoreguidelines-macro-usage,-warnings-as-errors]
PWGLF/Tasks/Strangeness/derivedlambdakzeroanalysis.cxx:102:8: error: constructor does not initialize these fields: isRun3, ccdb, mRunNumber, magField, maskTopological, maskTopoNoV0Radius, maskTopoNoDCANegToPV, maskTopoNoDCAPosToPV, maskTopoNoCosPA, maskTopoNoDCAV0Dau, maskTrackProperties, maskK0ShortSpecific, maskLambdaSpecific, maskAntiLambdaSpecific, maskSelectionK0Short, maskSelectionLambda, maskSelectionAntiLambda, secondaryMaskSelectionLambda, secondaryMaskSelectionAntiLambda [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
PWGLF/Tasks/Strangeness/derivedlambdakzeroanalysis.cxx:184:20: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGLF/Tasks/Strangeness/derivedlambdakzeroanalysis.cxx:202:67: error: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay,-warnings-as-errors]
PWGLF/Tasks/Strangeness/derivedlambdakzeroanalysis.cxx:467:16: error: redundant boolean literal in conditional assignment [readability-simplify-boolean-expr,-warnings-as-errors]
PWGLF/Tasks/Strangeness/derivedlambdakzeroanalysis.cxx:1278:5: error: do not use 'else' after 'return' [readability-else-after-return,-warnings-as-errors]
PWGLF/Tasks/Strangeness/derivedlambdakzeroanalysis.cxx:1305:28: error: the parameter 'collision' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param,-warnings-as-errors]
PWGLF/Tasks/Strangeness/derivedlambdakzeroanalysis.cxx:1366:44: error: the parameter 'v0' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param,-warnings-as-errors]
PWGLF/Tasks/Strangeness/derivedlambdakzeroanalysis.cxx:1366:59: error: the parameter 'collision' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param,-warnings-as-errors]
PWGLF/Tasks/Strangeness/derivedlambdakzeroanalysis.cxx:1629:37: error: the parameter 'v0' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param,-warnings-as-errors]
PWGLF/Tasks/Strangeness/derivedlambdakzeroanalysis.cxx:1812:29: error: the parameter 'v0' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param,-warnings-as-errors]
PWGLF/Tasks/Strangeness/derivedlambdakzeroanalysis.cxx:2211:46: error: the parameter #1 is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param,-warnings-as-errors]
PWGLF/Tasks/Strangeness/derivedlambdakzeroanalysis.cxx:2234:31: error: the parameter 'v0' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param,-warnings-as-errors]
PWGLF/Tasks/Strangeness/derivedlambdakzeroanalysis.cxx:2288:35: error: the parameter 'collision' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param,-warnings-as-errors]
PWGLF/Tasks/Strangeness/derivedlambdakzeroanalysis.cxx:2740:5: error: redundant return statement at the end of a function with a void return type [readability-redundant-control-flow,-warnings-as-errors]
PWGLF/Tasks/Strangeness/derivedlambdakzeroanalysis.cxx:2806:5: error: redundant return statement at the end of a function with a void return type [readability-redundant-control-flow,-warnings-as-errors]
++ [[ 143 -gt 0 ]]
++ cat /sw/BUILD/b48fe319e5a646cba02fea761b0ecd4b9e118204/O2Physics-code-check/warnings.txt
PWGLF/Tasks/Strangeness/derivedlambdakzeroanalysis.cxx:1113:24: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Strangeness/derivedlambdakzeroanalysis.cxx:1115:23: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Strangeness/derivedlambdakzeroanalysis.cxx:1117:27: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Strangeness/derivedlambdakzeroanalysis.cxx:1276:42: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Strangeness/derivedlambdakzeroanalysis.cxx:1278:47: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Strangeness/derivedlambdakzeroanalysis.cxx:1280:55: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Strangeness/derivedlambdakzeroanalysis.cxx:1282:46: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Strangeness/derivedlambdakzeroanalysis.cxx:1284:50: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Strangeness/derivedlambdakzeroanalysis.cxx:1286:47: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Strangeness/derivedlambdakzeroanalysis.cxx:1318:54: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Strangeness/derivedlambdakzeroanalysis.cxx:1343:22: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Strangeness/derivedlambdakzeroanalysis.cxx:1345:18: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Strangeness/derivedlambdakzeroanalysis.cxx:1347:17: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Strangeness/derivedlambdakzeroanalysis.cxx:1358:46: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Strangeness/derivedlambdakzeroanalysis.cxx:1360:45: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Strangeness/derivedlambdakzeroanalysis.cxx:1371:47: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Strangeness/derivedlambdakzeroanalysis.cxx:1373:50: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Strangeness/derivedlambdakzeroanalysis.cxx:1375:61: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Strangeness/derivedlambdakzeroanalysis.cxx:1377:61: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Strangeness/derivedlambdakzeroanalysis.cxx:1379:45: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Strangeness/derivedlambdakzeroanalysis.cxx:1381:53: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Strangeness/derivedlambdakzeroanalysis.cxx:1386:54: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Strangeness/derivedlambdakzeroanalysis.cxx:1389:55: warning: statement should be inside braces [readability-braces-around-statements]
[0 more errors; see full log]

Full log here.

@romainschotter
romainschotter merged commit b06f0ee into master Aug 8, 2026
12 of 16 checks passed
@romainschotter
romainschotter deleted the romainschotter-patch-2 branch August 8, 2026 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

2 participants