Skip to content

Casimir43/enhancement/660 update prg page to match newest figma design - #668

Merged
Skoivumaki merged 15 commits into
devfrom
casimir43/enhancement/660-update-prg-page-to-match-newest-figma-design
Sep 2, 2026
Merged

Casimir43/enhancement/660 update prg page to match newest figma design#668
Skoivumaki merged 15 commits into
devfrom
casimir43/enhancement/660-update-prg-page-to-match-newest-figma-design

Conversation

@Casimir43

Copy link
Copy Markdown

📄 Pull Request Overview

Closes #660

🔧 Changes Made

Added a tab switcher to flip between Action Plan, Annual Report, and Association Rules. Also cleaned up the board member section and applied new design features.

Checklist Before Submission

  • Functionality: I have tested my code, and it works as expected. ✅
  • JSDoc: I have added or updated JSDoc comments for all relevant code. ✅
  • Debugging: No console.log() or other debugging statements are left. ✅
  • Clean Code: Removed commented-out or unnecessary code. ✅
  • Tests: Added new tests or updated existing ones for the changes made. ✅
  • Documentation: Documentation has been updated (if applicable). ✅

📝 Additional Information

Screenshot_20260721_123838
  • On mobile, tabs show icons instead of text since small text doesn't fit well
  • On mobile, the document images move below the text so the text can use the full width

@Skoivumaki Skoivumaki left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small UI fixes:

  • Text overflows when in split-view. (good rule is, if website looks bad on larger tablets, split-view is going to break): Image

  • Your mobile implementation of CustomSwitch is clean, but in terms of user experience, its often bad to use icons to represent complex words. Simply fix it by disabling CustomSwitch for mobile and loop the tabs as seen in Figma example 1 (mobile). Just remember to make it look good and not overflow: Image

Otherwise everything looks good 👍

@eleino eleino left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, aside from the scaling issue on smaller screens, which is partly due to the Figma design using larger font sizes than usually. You could consider adding an intermediate breakpoint with a smaller font size so the page looks good on smaller screens as well.

onOpen: () => setActiveTab(tab),
children: isMobileSize ? (
/* eslint-disable-next-line @next/next/no-img-element */
<img

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One other thing: Why are you using <img> tag here instead of the Nextjs <Image> tag? In general we should avoid using code that requires disabling eslint checks if there are working alternatives.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was a good catch, I completely missed it... 😅

@Casimir43
Casimir43 requested a review from Skoivumaki August 10, 2026 07:36

@Skoivumaki Skoivumaki left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated mobile variant looks nice, good work 👍

@Rutjake Rutjake left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! Looks good.

@codecov-alt

codecov-alt Bot commented Aug 29, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 94.73684% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...migration/src/preparedPages/PRGPage/ui/PRGPage.tsx 94.73% 1 Missing ⚠️
Files with missing lines Coverage Δ
...migration/src/preparedPages/PRGPage/ui/PRGPage.tsx 97.61% <94.73%> (+97.61%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Skoivumaki
Skoivumaki merged commit 0a0f7b0 into dev Sep 2, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants