Skip to content

Eemeli/enhancement/659/about page update - #677

Open
EemeliJ wants to merge 19 commits into
devfrom
Eemeli/enhancement/659/about-page-update
Open

Eemeli/enhancement/659/about page update#677
EemeliJ wants to merge 19 commits into
devfrom
Eemeli/enhancement/659/about-page-update

Conversation

@EemeliJ

@EemeliJ EemeliJ commented Aug 25, 2026

Copy link
Copy Markdown
Contributor

📄 Pull Request Overview

Closes #659

🔧 Changes Made

Rebuilt the About / History page

  • Reworked the page structure around the project statistics, timeline and year-based content.
  • Added independent year blocks with expandable/collapsible accordion functionality.
  • Added a sorting dropdown for switching between newest and oldest timeline entries.
  • Added the designer credit section below the timeline.
  • Implemented responsive layouts for mobile, tablet and desktop.

Internationalization and content structure

  • Connected the new UI elements and timeline controls to i18n.
  • Structured designer information in the locale JSON so additional designers and their links can be added without changing the component.
  • Preserved the existing localized page content and metadata.

UI and interaction improvements

  • Added smooth open/close transitions for timeline entries.
    Implemented responsive timeline styling and controls across different viewport sizes.
  • Refined the statistics cards and timeline presentation to match the intended design.

Checklist Before Submission

  • Functionality: I have tested my code, and it works as expected. ✅
  • JSDoc: I have added or updated JSDoc comments for all relevant code. ✅
  • Debugging: No console.log() or other debugging statements are left. ✅
  • Clean Code: Removed commented-out or unnecessary code. ✅
  • Tests: Added new tests or updated existing ones for the changes made. ✅
  • Documentation: Documentation has been updated (if applicable). ✅

📝 Additional Information

Provide any additional context or information that reviewers may need to know:

  • Screenshots: [Include any screenshots or videos if the changes affect the UI]

Desktop with closed entries:
AboutDesktopClosed

Open entry in desktop:
DesktopOpenEntry

Mobile fullsize closed: (Note: the footer and header don't actually behave like this)
MobileThinFullsizeClosed

Mobile fullsize with open entries:
MobileThinFullsizeOpen

Actual look of mobile upper and lower areas:
-Upper:
MobileThinUpper

-Lower:
MobileThinLower

Ipad:
-Upper:
IpadUpper

-Lower:
IpadLower

Translations:
AboutENG

  • Dependencies: No new dependencies were added.
  • Known Issues: No known functional issues.

EemeliJ added 17 commits July 15, 2026 11:57
…dded statistic card styling, simplified the statistics section, aligned the layout with the Figma design, and updated the statistics heading.
…tates, also fixed some positioning and rendering issues with the ellipses and arrows in the timeline
…rectly for sorting dropdown and close button and made some other minor tweaks to dropdown chevron, statcard size and various fonts
… designers personal page, can be expanded later through i18n.
@codecov-alt

codecov-alt Bot commented Aug 25, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 57 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...migration/src/preparedPages/AboutPage/ui/About.tsx 0.00% 17 Missing ⚠️
...n/src/preparedPages/AboutPage/ui/TimelineEntry.tsx 0.00% 16 Missing ⚠️
...ration/src/preparedPages/AboutPage/ui/Timeline.tsx 0.00% 13 Missing ⚠️
...shared/ui/DropdownWrapperV2/ui/DropdownWrapper.tsx 0.00% 11 Missing ⚠️
Files with missing lines Coverage Δ
...shared/ui/DropdownWrapperV2/ui/DropdownWrapper.tsx 0.00% <0.00%> (ø)
...ration/src/preparedPages/AboutPage/ui/Timeline.tsx 0.00% <0.00%> (ø)
...n/src/preparedPages/AboutPage/ui/TimelineEntry.tsx 0.00% <0.00%> (ø)
...migration/src/preparedPages/AboutPage/ui/About.tsx 0.00% <0.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Casimir43 Casimir43 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work on the About page!

Comment on lines 11 to 14

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One thing i noticed is that: description and keywords are still in the Props interface but are not destructed or used in the component. might wanna remove them from the interface too.
looks like it was just forgotten code.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, looks like i forgot to remove them, i'll go ahead and do that next 👍

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can easily check for lint errors by using npm run lint. This way you wont miss any unused props or other errors like it 😄

@EemeliJ
EemeliJ requested a review from Casimir43 September 3, 2026 08:07

@Skoivumaki Skoivumaki left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work!
Some stuff:

  • Make sure the first entry is open, so that the user has something to read when they land on the page.

  • Although you did as in Figma design, I think it looks too crowded. Add some padding between the elements:

Image

…up the page to open the first timeline entry when loaded
@EemeliJ
EemeliJ requested a review from Skoivumaki September 11, 2026 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants