Casimir43/enhancement/667 refactor desktop navbar - #680
Open
Casimir43 wants to merge 8 commits into
Open
Conversation
- drop the unused isCollapsed prop, its class toggles, and the auth/lang dropdown guards it fed into - remove the 4 unused .collapsed style blocks from the module stylesheet
- cover nav element, top-level triggers, open-on-hover with the dropdownMenuOpen class, close-on-leave, and Escape dismissal - verify marginTop style and custom className props
Casimir43
requested review from
Rutjake,
Skoivumaki,
leolabdev and
patinen
as code owners
August 31, 2026 08:56
|
It seems that you forgot to switch main branch to dev: 
|
|
Great work! Looks like you have followed the proposed implementation of the issue very well. |
Author
Good catch. Switched to dev |
Skoivumaki
requested changes
Sep 11, 2026
Skoivumaki
left a comment
Skoivumaki
left a comment
Member
There was a problem hiding this comment.
Incredible, I found nothing to complain about at all. Navbar looks and functions perfectly! 👍
So Im gonna nitpick instead: when viewport is between 1201-1300px the action buttons collide with navbar text. This is a very rare case scenario and unlikely to happen, but it does. I noticed the larger text breakpoint is above 1200px, so maybe make it actually trigger above 1300px? (if possible)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📄 Pull Request Overview
Closes #667
🔧 Changes Made
Refactored the desktop navbar to render a per-item dropdown under each link instead of full-width dropdown bar. Each dropdown opens on hover and closes on escape or outside click.
Cleaned dead code: removed unused isCollapsed prop and unused .collapsed from scss.
Added simple test covering render, triggers,hover/close, escape dismissal and classname props.
✅ Checklist Before Submission
console.log()or other debugging statements are left.✅📝 Additional Information
Provide any additional context or information that reviewers may need to know:
Mobile still filters dropdown items out of the hamburger menu.