Rename WebSocketDataCallback's frame param from opcode to bits - #9
Open
heshammahamed wants to merge 1 commit into
Open
Rename WebSocketDataCallback's frame param from opcode to bits#9heshammahamed wants to merge 1 commit into
heshammahamed wants to merge 1 commit into
Conversation
The parameter was named `opcode`, but civetweb actually passes the raw first byte of the WebSocket frame header (FIN flag + reserved bits + the real opcode packed into the low 4 bits), not the opcode alone. Renamed to `bits` to match civetweb's own naming, and updated the docs (EN + AR) and examples to match this correct understanding.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The parameter was named
opcode, but civetweb actually passes the raw first byte of the WebSocket frame header (FIN flag + reserved bits + the real opcode packed into the low 4 bits), not the opcode alone. Renamed tobitsto match civetweb's own naming, and updated the docs (EN + AR) and examples to match this correct understanding.