fix: fresh-DB ordering, IDEMPOTENCY_CONFLICT constraint, remove dead finance-llm - #73
Merged
Merged
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Aparnap2
commented
Sep 28, 2026
Aparnap2
left a comment
Aparnap2
left a comment
Owner
Author
There was a problem hiding this comment.
Technical review: ACCEPT pending human merge.
- 012 idempotency audit allowlist fix addresses a genuine live CheckViolation path.
- Stripe/tenant fresh-DB verification is restored.
- Dead finance/llm provider stack is removed; canonical shared LLM path remains.
- Legacy finance.approval modules are correctly left untouched because live importers still exist.
- Exact 10-file scope; frozen P6/P7/P8 contracts untouched.
- No new regression reported.
Next: human-merge PR #73. Then open the AWS/deployment work and keep the remaining approval-stack consolidation as a separate bounded task. Do not redesign P8.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two fixes + one removal, frozen contracts untouched. (1) fix(db) 012 admits IDEMPOTENCY_CONFLICT audit writes — genuine live defect: webhooks.py persists a value 003's allowlist forbids; stripe fixture now self-sufficient via shared migration chain. Verified 8/8 stripe+tenant on fresh DB. (2) chore: delete dead finance/llm/* (5 modules, proven unreachable) + its 2 dedicated test files; quarantine docstring. Legacy importers of finance.approval.authorization kept deliberately — deeper consolidation needs adjudication. Regression: zero new failures (adjusted baseline accounts deleted network-dependent tests). Production claim unchanged: NOT READY (AWS + live-model qualification pending).