Fixes to FOV and implane-utils for correct flat_lamp scaling - #1007
Open
janusbrink wants to merge 1 commit into
Open
Fixes to FOV and implane-utils for correct flat_lamp scaling#1007janusbrink wants to merge 1 commit into
janusbrink wants to merge 1 commit into
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1007 +/- ##
===========================================
- Coverage 76.44% 29.38% -47.07%
===========================================
Files 69 67 -2
Lines 9030 8906 -124
===========================================
- Hits 6903 2617 -4286
- Misses 2127 6289 +4162 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After careful verification of scopesim_targets::Flat lamp behaviour these fixes to ScopeSim are needed so that extended sources are consistently rendered when the source pixel scale is changed and comparing 2+1D vs 3D (cube) source variants.
Note: Additional debug log prints were added, some may be too heavy to keep?