fix(mobile): render Discover Weekly as a lineup with a header tile - #14578
Merged
Conversation
The screen wrapped the artwork header and the entire track list in one full-height Paper, so it read as a single full-page tile with the lineup nested inside it. Move the header into the lineup's ListHeaderComponent so the track tiles render as a normal lineup on the screen background, matching Trending / Remixes / Listening History. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The native Discover Weekly screen wrapped the artwork header and the entire track list in one
<Paper m='l' h='100%'>, so the whole page read as a single full-page tile with the lineup nested inside it.This moves the header into the lineup's
ListHeaderComponentso it renders as a normal lineup with a header tile on top — same shape as Trending / Remixes / Listening History.Papertile, passed viaTrackLineup'sheaderprop.TrackLineupnow renders directly underScreenContent, so track tiles sit on the screen background.ph='l' pt='l'to line up withTrackLineup's own 16px item padding.'DISCOVER_WEEKLY_TRACKS'string literal for the existingDISCOVER_WEEKLY_SOURCEconstant already used for the playback queue.Follow-up to #14574.
Testing
tscand eslint clean forpackages/mobile. Layout-only change — no behavior, playback, or analytics changes.🤖 Generated with Claude Code