[Resource] Fix #34004: az resource wait: Raise CLIError on timeout instead of returning it

[Aditya Pujara (a0x1ab)]

Description

Fixes #34004.

Related command
az resource wait (and all subcommands sharing WaitCommandOperation)

Description

WaitCommandOperation.wait was using return CLIError(...) on timeout instead of raise CLIError(...). The return value was silently discarded by callers, causing timed-out waits to exit with code 0 and no error output — indistinguishable from success.

• command_operation.py: return CLIError(...) → raise CLIError(...) at timeout path
• test_wait_command_operation.py (new): unit tests asserting CLIError is raised on timeout and None is returned on success

Testing Guide

# Timeout path — previously exited 0 with no output, now raises CLIError
az resource wait --ids <resource-id> --custom "nonExistentProperty=='value'" --timeout 5
# Expected: CLIError: Wait operation timed-out after 5 seconds (exit code 1)

Unit tests added to src/azure-cli-core/azure/cli/core/tests/test_wait_command_operation.py.

History Notes

[Core] az resource wait: Fix timeout path to raise CLIError instead of silently returning it

[azure-pipelines]

Azure Pipelines:
There may be pipelines that require an authorized user to comment /azp run to run.

[Copilot]

Pull request overview

This PR fixes az resource wait timeout handling by raising a CLIError instead of returning a CLIError object that callers discard, ensuring timeouts fail with a non-zero exit code and an error message.

Changes:

• Change WaitCommandOperation.wait timeout path from return CLIError(...) to raise CLIError(...).
• Add unit tests verifying timeout raises CLIError and successful waits return None.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File	Description
src/azure-cli-core/azure/cli/core/commands/command_operation.py	Fixes timeout path to raise an error so az resource wait correctly fails on timeout.
src/azure-cli-core/azure/cli/core/tests/test_wait_command_operation.py	Adds regression tests for timeout/error behavior and successful return behavior.

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[azure-client-tools-agent]

Live test skipped

⏭️ Skipping the live test for this revision because the only test file(s) changed are azure-cli-core unit tests, which the live-test pipeline (azdev test --live) does not run — it covers command-module and extension tests only.

These azure-cli-core tests are exercised by upstream CI's unit-test jobs instead. This is informational; no action is required.

[Yong Zhang (yonzhan)]

Resource

[azure-client-tools-agent]

Aditya Pujara (@a0x1ab)

Automated Review Summary — PASS

CI: 19/19 completed checks passed, 0 failed. 3 checks
(Azure.azure-cli Breaking Change Test, Azure.azure-cli Full Test,
Azure.azure-cli) have been stuck in queued for ~198 minutes, well past the
180-minute abandoned threshold. A re-trigger attempt (rerun_stale_pr_checks)
returned 0 re-requested (cooldown or provider refusal), so these are treated
as zombie/abandoned checks rather than blocking failures. No completed check
has failed.

Live test: Skipped — the PR only changes
src/azure-cli-core/azure/cli/core/commands/command_operation.py and a new
unit test test_wait_command_operation.py; azure-cli-core unit tests are
not runnable via azdev test --live.

Regression coverage: Not applicable — the change is in azure-cli-core
infrastructure code, not a command module, so the module-coverage gap check
does not apply.

Review-skill findings: None. Reviewed against test-strength and
scope-consistency checks:

• The change is a single-line fix (return CLIError(...) → raise CLIError(...)) in WaitCommandOperation.wait, matching the PR title/issue
  scope exactly (az resource wait raising instead of returning on timeout).
• The added unit test test_wait_command_operation.py asserts
  WaitCommandOperation.wait raises CLIError on timeout
  (test_wait_raises_on_timeout) and still returns None on the success path
  (test_wait_returns_none_on_success) — both assertions can fail if the
  implementation regresses, and the negative/timeout path is exercised.

Recommendation: No source changes requested. A maintainer may want to
manually re-run or inspect the 3 stuck Azure DevOps checks before merge, since
Azure Client Tools Agent could not re-trigger them, but nothing indicates a
PR-related failure.

[microsoft-github-policy-service]

🔔 Routing this PR to @Azure/act-identity-squad.