fix(ai-agents): propagate local agent exit failures - #9600
Open
Dooriya Li (dooriya) wants to merge 1 commit into
Open
fix(ai-agents): propagate local agent exit failures#9600Dooriya Li (dooriya) wants to merge 1 commit into
Dooriya Li (dooriya) wants to merge 1 commit into
Conversation
Capture cancellation state before cleanup cancels the run context, so non-zero child process exits are returned instead of reported as a clean stop. Fixes Azure#9599 Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
|
Azure Pipelines: Successfully started running 1 pipeline(s). 6 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes local agent exit failures being incorrectly reported as successful.
Changes:
- Preserves cancellation state before cleanup.
- Adds a cross-platform non-zero exit regression test.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
internal/cmd/run.go |
Distinguishes cancellation from process failure. |
internal/cmd/run_test.go |
Tests propagation of exit status 17. |
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
|
||
| err = proc.Wait() | ||
| close(done) | ||
| wasCanceled := ctx.Err() != nil |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Agent stopped.successfullyValidation
go test ./internal/cmdgo vet ./internal/cmdFixes #9599