[Resources] Point what-if noise notice to Deployment Stacks What-if with reduced noise - #30048
Closed
Torrey Trahanovsky (torreymicrosoft) wants to merge 2 commits into
Closed
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Contributor
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
Copilot started reviewing on behalf of
Torrey Trahanovsky (torreymicrosoft)
August 21, 2026 15:56
View session
Contributor
There was a problem hiding this comment.
Pull request overview
Removes the older “open an issue” call-to-action from the template-deployment what-if “noise” notice so the notice provides a single, clearer next step (move to Deployment Stacks What-If).
Changes:
- Removed the
aka.ms/WhatIfIssuesline from the localizedWhatIfNoiseNoticeresource value. - Updated the generated
Resources.Designer.csXML doc comment to match the updated.resxtext. - Extended the existing Upcoming Release changelog entry to mention the removal.
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/Resources/Resources/ChangeLog.md | Extends the existing unreleased entry to mention the removed notice line. |
| src/Resources/ResourceManager/Properties/Resources.resx | Removes the older issue-link sentence from the WhatIfNoiseNotice resource value. |
| src/Resources/ResourceManager/Properties/Resources.Designer.cs | Keeps the generated summary comment aligned with the updated .resx value. |
Files not reviewed (1)
- src/Resources/ResourceManager/Properties/Resources.Designer.cs: Generated file
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+22
to
+23
| * Added a notice to template deployment what-if output pointing users to Deployment Stacks What-If, which is now generally available and removes noise from results. | ||
| - Removed the preceding line asking users to open an issue at `https://aka.ms/WhatIfIssues`, so the notice offers a single next step. |
Member
|
/azp run |
Contributor
|
Azure Pipelines: Successfully started running 3 pipeline(s). |
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot started reviewing on behalf of
Torrey Trahanovsky (torreymicrosoft)
August 21, 2026 16:28
View session
Torrey Trahanovsky (torreymicrosoft)
changed the title
Member
|
/azp run |
Contributor
|
Azure Pipelines: Successfully started running 3 pipeline(s). |
| <value>Note: The result may contain false positive predictions (noise). | ||
| You can help us improve the accuracy of the result by opening an issue here: https://aka.ms/WhatIfIssues. | ||
| NOTICE! - Want to get What-if without noise? Move to Deployment Stacks What-If https://aka.ms/stackswhatifGA</value> | ||
| NOTICE! - Want to get What-if with reduced noise? Move to Deployment Stacks What-if https://aka.ms/stackswhatifGA</value> |
There was a problem hiding this comment.
This reads a bit too much like an ad..
Can we only amend what is there:
Note: The result may contain false positive predictions (noise). For what-if with noise reduction, consider Deployment Stacks (https://aka.ms/stackswhatifGA)
This was referenced Aug 27, 2026
Member
Author
|
Superseded by #30077, which is branched from current \main\ and implements Alex Frankel (@alex-frankel)'s review feedback from this PR verbatim (amend the existing sentence rather than appending a separate notice line). Closing in favor of that PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 PR Validation —⚠️ Review suggested
️✔️Az.Accounts
️✔️Az.KeyVault
️✔️Az.ManagedServiceIdentity
️✔️Az.Monitor
️✔️Az.Network
Description
Follow-up to #30046, which added a line pointing template deployment what-if users to Deployment Stacks What-if now that it is generally available.
This PR does two things:
What-ifcapitalization for both occurrences."Reduced noise" is the accurate claim: Stacks What-if filters noise against a baseline recorded when the stack was deployed, which substantially reduces false positives rather than eliminating them outright.
Affected output:
New-AzDeploymentWhatIf/New-AzResourceGroupDeploymentWhatIfand the equivalent subscription, management group, and tenant cmdlets, plus the what-if preview rendered by the deployment create cmdlets.Before
After
Changes
src/Resources/ResourceManager/Properties/Resources.resx— updated theWhatIfNoiseNoticevalue.src/Resources/ResourceManager/Properties/Resources.Designer.cs— kept the generated doc comment in sync with the.resx. Comment only; the accessor is unchanged.src/Resources/Resources/ChangeLog.md— extended the existing unreleased entry, since both changes ship in the same release, and aligned its capitalization and wording.Scope / risk
WhatIfNoiseNoticeis consumed only byWhatIfOperationResultFormatter.FormatNoiseNotice(), which formatsPSWhatIfOperationResultfor template deployment what-if.PSDeploymentStackWhatIfResultand is formatted separately, so it is not touched.https://aka.ms/WhatIfIssueshas no remaining code references undersrc/, so nothing is left orphaned.src/Resources/Resources.Test/Formatters/WhatIfOperationResultFormatterTests.csassert withAssert.Contains/Assert.EndsWithagainst legend, change, stats, and diagnostic content. None include the noise notice, and theAssert.EndsWithcase targets the trailing stats line while the notice is emitted at the top, so no test updates are required.