Skip to content

Updating App Config test resources - #48769

Open
Matthew Metcalf (mrm9084) wants to merge 1 commit into
Azure:mainfrom
mrm9084:FixArmTemplate
Open

Updating App Config test resources#48769
Matthew Metcalf (mrm9084) wants to merge 1 commit into
Azure:mainfrom
mrm9084:FixArmTemplate

Conversation

@mrm9084

Copy link
Copy Markdown
Member

Description

Updates the test structure of the python libraries.

  • Removed the unused connection string
  • Updated api version in template
  • Removed unused keys, we make them in the tests
  • Added a check at the start of testing to make sure the role has propagated to the resource before testing starts.

Copilot AI balanced review requested due to automatic review settings August 26, 2026 20:06
@github-actions github-actions Bot added the App Configuration Azure.ApplicationModel.Configuration label Aug 26, 2026
@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 1 pipeline(s).
9 pipeline(s) were filtered out due to trigger conditions.
There may be pipelines that require an authorized user to comment /azp run to run.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates App Configuration test resources to use RBAC-only authentication and tolerate role-assignment propagation delays.

Changes:

  • Modernizes the ARM template and removes unused connection-string/key resources.
  • Adds live-test readiness checks with bounded exponential backoff.
  • Adds unit coverage for success, retry, error, and timeout paths.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file
File Description
sdk/appconfiguration/test-resources.json Updates resource provisioning and outputs.
sdk/appconfiguration/azure-appconfiguration/tests/conftest.py Adds RBAC readiness fixture.
sdk/appconfiguration/azure-appconfiguration/tests/test_readiness.py Tests readiness behavior.
sdk/appconfiguration/azure-appconfiguration-provider/tests/conftest.py Orders setup after readiness and uses test credentials.
sdk/appconfiguration/azure-appconfiguration-provider/tests/test_readiness.py Tests provider readiness behavior.

💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.

Copilot AI commented Aug 26, 2026

Copy link
Copy Markdown
Contributor

One or more custom setup steps configured for this repository failed during this Copilot code review run:

Install azsdk mcp server

Setup steps run before each review. If the review above is missing context, or no review was posted at all, the failing step above may be the cause. See the workflow run for failure details, fix your setup steps configuration, and re-request a review.

Note

You can configure setup steps for Copilot code review separately from Copilot cloud agent with a copilot-code-review.yml file. Read the docs for details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

App Configuration Azure.ApplicationModel.Configuration

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants