Skip to content

[Storage] added headers to redirect cleanup logic - #48771

Open
anjaliratnam-msft wants to merge 1 commit into
Azure:mainfrom
anjaliratnam-msft:headers-fix
Open

[Storage] added headers to redirect cleanup logic#48771
anjaliratnam-msft wants to merge 1 commit into
Azure:mainfrom
anjaliratnam-msft:headers-fix

Conversation

@anjaliratnam-msft

Copy link
Copy Markdown
Member

Added the following encryption headers to the redirect cleanup logic:

  • x-ms-encryption-key
  • x-ms-encryption-key-sha256
  • x-ms-source-encryption-key
  • x-ms-source-encryption-key-sha256

Copilot AI balanced review requested due to automatic review settings August 26, 2026 20:11
@github-actions github-actions Bot added the Storage Storage Service (Queues, Blobs, Files) label Aug 26, 2026
@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 1 pipeline(s).
9 pipeline(s) were filtered out due to trigger conditions.
There may be pipelines that require an authorized user to comment /azp run to run.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Expands cross-domain redirect cleanup to prevent customer-provided encryption keys from being forwarded.

Changes:

  • Adds four encryption headers to all Storage cleanup policies.
  • Extends Blob redirect tests to verify their removal.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file
File Description
azure-storage-queue/.../policies.py Adds encryption headers to cleanup defaults.
azure-storage-file-share/.../policies.py Adds encryption headers to cleanup defaults.
azure-storage-file-datalake/.../policies.py Adds encryption headers to cleanup defaults.
azure-storage-blob/.../policies.py Adds encryption headers to cleanup defaults.
azure-storage-blob/tests/test_sensitive_redirect.py Tests cleanup of the added headers.

💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Storage Storage Service (Queues, Blobs, Files)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants