Upgrade dependencies for .NET 8 - #1385
Open
Bernd Verst (berndverst) wants to merge 1 commit into
Open
Conversation
Preserve netstandard2.0 and .NET Framework 4.7.2+ compatibility while modernizing packages and related APIs. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: cc0975a2-b849-4657-a61b-0166df132157
![github-code-quality[bot]](https://avatars.githubusercontent.com/u/9919?s=60&v=4){kind=small}
| Assert.AreEqual(message, JToken.Parse(status?.Output)); | ||
| Assert.AreEqual(message, JToken.Parse(status.Input)); | ||
| Assert.AreEqual(message, JToken.Parse(status?.Output).Value<string>()); | ||
| Assert.AreEqual(message, JToken.Parse(status.Input).Value<string>()); |
Contributor
There was a problem hiding this comment.
Pull request overview
Upgrades and modernizes dependency versions across the product, tests, samples, and Service Fabric assets to support building and running with the .NET 8 SDK while retaining netstandard2.0, net472, and net48 compatibility.
Changes:
- Updated centrally managed package versions (Azure SDKs, MSTest 4.x, System.* libraries, OpenTelemetry) and adjusted projects to match.
- Migrated breaking API usages (MSTest “ThrowsExactly*”, CommandLineParser 2.9 parsing/help patterns, System.Linq.Async overload changes, consolidated System.Reactive package).
- Updated Service Fabric build tooling and pinned patched legacy transitives for Service Bus/storage scenarios.
Reviewed changes
Copilot reviewed 46 out of 46 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| test/TestFabricApplication/TestApplication/TestApplication.sfproj | Update Service Fabric MSBuild package import/version references. |
| test/TestFabricApplication/TestApplication/packages.config | Bump Service Fabric MSBuild NuGet package version. |
| test/DurableTask.Stress.Tests/Program.cs | Migrate CLI parsing to CommandLineParser 2.9 API pattern. |
| test/DurableTask.Stress.Tests/Options.cs | Consolidate options to CommandLineParser 2.9 attributes/help generation. |
| test/DurableTask.ServiceBus.Tests/ServiceBusOrchestrationServiceTests.cs | Adjust JSON assertions for stricter MSTest/runtime behavior. |
| test/DurableTask.ServiceBus.Tests/SampleScenarioTests.cs | Switch to MSTest ThrowsExactlyAsync for precise exception assertions. |
| test/DurableTask.ServiceBus.Tests/OrchestrationHubTableClientTests.cs | Normalize assert argument ordering and null assertions. |
| test/DurableTask.ServiceBus.Tests/InstanceStoreQueryTests.cs | Replace Assert.IsTrue(false) with Assert.Fail(). |
| test/DurableTask.ServiceBus.Tests/ErrorHandlingTests.cs | Re-enable [TestMethod] while keeping test ignored. |
| test/DurableTask.ServiceBus.Tests/DurableTask.ServiceBus.Tests.csproj | Add net8-only package needed after dependency upgrades. |
| test/DurableTask.Emulator.Tests/EmulatorFunctionalTests.cs | Use MSTest ThrowsExactlyAsync for conflict checks. |
| test/DurableTask.Core.Tests/WorkItemDispatcherTests.cs | Align ILogger.BeginScope signature with newer logging abstractions. |
| test/DurableTask.Core.Tests/TraceContextBaseTest.cs | Use ThrowsExactly for strict exception matching. |
| test/DurableTask.Core.Tests/RetryInterceptorTests.cs | Update exception assertions and test method attributes for MSTest 4. |
| test/DurableTask.Core.Tests/ExceptionHandlingIntegrationTests.cs | Update test attributes for MSTest 4 behavior. |
| test/DurableTask.Core.Tests/DispatcherMiddlewareTests.cs | Update data-driven test attributes for MSTest 4 behavior. |
| test/DurableTask.Core.Tests/ContinueAsNewTraceBehaviorTests.cs | Replace ExpectedException with Assert.ThrowsExactly lambdas. |
| test/DurableTask.AzureStorage.Tests/TestTablePartitionManager.cs | Normalize assertions; minor test reliability/readability tweaks. |
| test/DurableTask.AzureStorage.Tests/StressTests.cs | Update data-driven test attributes for MSTest 4 behavior. |
| test/DurableTask.AzureStorage.Tests/Storage/TableDeleteBatchParallelTests.cs | Use ThrowsExactlyAsync for cancellation assertions. |
| Test/DurableTask.AzureStorage.Tests/Storage/DurableTaskStorageExceptionTests.cs | Update data-driven test attributes for MSTest 4 behavior. |
| test/DurableTask.AzureStorage.Tests/Net/UriPathTests.cs | Update data-driven test attributes for MSTest 4 behavior. |
| test/DurableTask.AzureStorage.Tests/MessageManagerTests.cs | Update data-driven test attributes and strict exception assertions. |
| test/DurableTask.AzureStorage.Tests/KeySanitationTests.cs | Update data-driven test attributes for MSTest 4 behavior. |
| test/DurableTask.AzureStorage.Tests/DurableTask.AzureStorage.Tests.csproj | Adjust package pins/groups to align with updated dependency graph. |
| test/DurableTask.AzureStorage.Tests/Correlation/StringExtensionsTest.cs | Use ThrowsExactly for strict exception matching. |
| test/DurableTask.AzureStorage.Tests/Correlation/CorrelationScenarioTest.cs | Update data-driven test attributes for MSTest 4 behavior. |
| test/DurableTask.AzureStorage.Tests/AzureTableQueryFilterTests.cs | Update data-driven test attributes for MSTest 4 behavior. |
| test/DurableTask.AzureStorage.Tests/AzureStorageScenarioTests.cs | Update data-driven test attributes and JSON assertions. |
| test/DurableTask.AzureStorage.Tests/AzureStorageScaleTests.cs | Update data-driven test attributes and strict exception assertions. |
| test/DurableTask.AzureStorage.Tests/AsyncAutoResetEventTests.cs | Update data-driven test attributes and assertion ordering. |
| test/DurableTask.AzureServiceFabric.Tests/DurableTask.AzureServiceFabric.Tests.csproj | Remove version overrides; rely on central package management. |
| test/DurableTask.AzureServiceFabric.Tests/App.config | Remove outdated binding redirects after dependency updates. |
| Test/DurableTask.AzureServiceFabric.Tests/AllowedTypesSerializationBinderTests.cs | Use ThrowsExactly* for strict exception matching. |
| test/DurableTask.AzureServiceFabric.Integration.Tests/FunctionalTests.cs | Replace ExpectedException with explicit ThrowsExactlyAsync patterns. |
| test/DurableTask.AzureServiceFabric.Integration.Tests/DurableTask.AzureServiceFabric.Integration.Tests.csproj | Remove package version overrides; rely on central package management. |
| test/DurableTask.AzureServiceFabric.Integration.Tests/DeploymentUtil/DeploymentHelper.cs | Update Service Fabric client call to new overload requiring options. |
| test/DurableTask.AzureServiceFabric.Integration.Tests/App.config | Remove outdated binding redirects after dependency updates. |
| src/DurableTask.ServiceBus/DurableTask.ServiceBus.csproj | Pin patched legacy transitives and add net48-only dependencies. |
| src/DurableTask.Core/DurableTask.Core.csproj | Consolidate reactive dependencies to System.Reactive. |
| src/DurableTask.AzureStorage/OrchestrationSessionManager.cs | Adjust LINQ-async ToDictionaryAsync call for updated overloads. |
| samples/DurableTask.Samples/Program.cs | Migrate CLI parsing to CommandLineParser 2.9 API pattern. |
| samples/DurableTask.Samples/Options.cs | Update option attributes and help generation for CommandLineParser 2.9. |
| samples/DistributedTraceSample/README.md | Update prerequisites to .NET 8 SDK and markdown formatting. |
| samples/DistributedTraceSample/ApplicationInsights/README.md | Update prerequisites to .NET 8 SDK and markdown formatting. |
| Directory.Packages.props | Central package version upgrades and framework-scoped dependency reshaping. |
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
| @@ -476,7 +476,7 @@ public async Task ForceTerminate_Already_Finished_Orchestration() | |||
|
|
|||
| var reason = "Testing terminatiom of already finished orchestration"; | |||
| @@ -716,8 +716,8 @@ await WaitForConditionAsync( | |||
| // guarantee table is corrrectly updated | |||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
netstandard2.0,net472, andnet48support.Compatibility notes
Validation
netstandard2.0,net8.0,net472, andnet48surfaces.