Avdunn/pipeline fix - #954
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates MSAL Python’s Azure DevOps/OneBranch release pipeline configuration to address issues in the publish flow (including build and artifact handling) that were previously applied in a preview branch but never merged.
Changes:
- Adds/updates OneBranch Windows configuration inputs (host version + container image variable).
- Modifies the Build stage to run on a Windows pool and adjusts the dist artifact copy behavior.
- Adjusts artifact download inputs/paths and updates ESRP owners/approvers for the PyPI publish stage.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+93
to
97
| - script: python --version | ||
| displayName: 'Check Python version' | ||
|
|
||
| - script: | | ||
| python -m pip install --upgrade pip build twine | ||
| displayName: 'Install build toolchain' | ||
|
|
||
| - script: | | ||
| python -m build | ||
| - script: python setup.py sdist bdist_wheel | ||
| displayName: 'Build sdist and wheel' |
Comment on lines
129
to
135
| - task: DownloadPipelineArtifact@2 | ||
| displayName: 'Download build artifact' | ||
| inputs: | ||
| artifactName: drop_Build_BuildDist | ||
| targetPath: $(Pipeline.Workspace)/python-dist | ||
| buildType: 'current' | ||
| artifactName: 'drop_Build_BuildDist' | ||
| targetPath: $(Pipeline.Workspace)\python-dist | ||
|
|
Gladwin Johnson (gladjohn)
approved these changes
Aug 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Various fixes for MSAL Python's release pipeline. These fixes were previously applied to a branch that was used for a preview release, but they were reversed before that PR was merged and the fixes were never given their own PR: #944