Skip to content

🔄 updated Bruno module to version 4.0.0 - #29

Merged
jwaisner merged 2 commits into
mainfrom
4.0
Jul 25, 2026
Merged

jwaisner merged 2 commits into
mainfrom
4.0

Conversation

@N6REJ

@N6REJ N6REJ commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@N6REJ
N6REJ requested a review from jwaisner July 23, 2026 23:03
@N6REJ N6REJ added the enhancement ✨ Improve program label Jul 23, 2026
@qodo-code-review

Copy link
Copy Markdown
Contributor

PR Summary by Qodo

Add Bruno v4.0.0 module config and bump bundle release date

✨ Enhancement ⚙️ Configuration changes 🕐 Less than 5 minutes

Grey Divider

AI Description

• Add a new versioned Bruno module config for 4.0.0 (bruno.exe).
• Update the bundle release date to 2026.7.23 for packaging/version metadata.
Diagram

graph TD
  C1[/"build.properties"/] --> P["Gradle release build"] --> O(["Bruno module 7z"])
  C2[/"bearsampp.conf (4.0.0)"/] --> P
  E{{"modules-untouched releases"}} --> P

  subgraph Legend
    direction LR
    _cfg[/"Config file"/] ~~~ _proc["Build step"] ~~~ _ext{{"External"}} ~~~ _out(["Artifact"])
  end
Loading
High-Level Assessment

The following are alternative approaches to this PR:

1. Generate bearsampp.conf during the Gradle build
  • ➕ Removes manual per-version config file maintenance
  • ➕ Avoids copy/paste drift between version directories
  • ➖ Adds build logic/templating complexity
  • ➖ May break expectations of consumers that rely on checked-in version directories/files
2. Maintain only a single 'current' bruno directory instead of versioned dirs
  • ➕ Less repo clutter and simpler directory structure
  • ➖ Loses ability to build/reproduce older module versions from the repo
  • ➖ Requires broader changes to tooling/docs that assume versioned directories

Recommendation: Keep the current approach (add a versioned bearsampp.conf and bump bundle.release) because it matches the established versioned layout and keeps the build workflow simple and predictable. Consider build-time generation only if per-version config files become a maintenance burden.

Files changed (2) +3 / -1

Other (2) +3 / -1
bearsampp.confAdd module config for Bruno 4.0.0 +2/-0

Add module config for Bruno 4.0.0

• Introduces a new version directory configuration declaring Bruno version 4.0.0 and the executable name (bruno.exe). This enables building/packaging the module for this new upstream version.

bin/bruno4.0.0/bearsampp.conf

build.propertiesBump bundle release date to 2026.7.23 +1/-1

Bump bundle release date to 2026.7.23

• Updates the bundle.release property from 2026.7.14 to 2026.7.23, which updates the module’s release metadata/version used by the Gradle build.

build.properties

@qodo-code-review

Copy link
Copy Markdown
Contributor

Code Review by Qodo

🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)

Grey Divider

Great, no issues found!

Qodo reviewed your code and found no material issues that require review

Grey Divider

Qodo Logo

@jwaisner
jwaisner merged commit a45f790 into main Jul 25, 2026
2 checks passed
@jwaisner
jwaisner deleted the 4.0 branch July 25, 2026 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement ✨ Improve program

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants