Skip to content

xlight 3.9.5 #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
N6REJ merged 3 commits into from
Aug 10, 2026
Merged

xlight 3.9.5 #6

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3752e12
Add xlight 3.9.5 module with configuration files
jwaisner Aug 10, 2026
891b7b2
Update bundle release version to 2026.8.9
N6REJ Aug 10, 2026
9effff7
Merge branch 'main' into 3.9.5
N6REJ Aug 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Empty file added bin/xlight3.9.5/Logs/.gitignore
View file
Open in desktop
Empty file.
4 changes: 4 additions & 0 deletions bin/xlight3.9.5/bearsampp.conf
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
xlightVersion = "3.9.5"
xlightExe = "xlight.exe"
xlightPort = "21"
xlightSslPort = "990"
3 changes: 3 additions & 0 deletions bin/xlight3.9.5/extras.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
help = https://github.com/Bearsampp/modules-untouched/releases/download/xlight-2026.8.9/xlight_help.zip
remote = https://github.com/Bearsampp/modules-untouched/releases/download/xlight-2026.8.9/remote_admin.zip
language = https://github.com/Bearsampp/modules-untouched/releases/download/xlight-2026.8.9/language_en.zip
5 changes: 5 additions & 0 deletions bin/xlight3.9.5/ftpd.hosts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
<virtualserver 127.0.0.1:21>
EnableUTF8:yes
ServerNotes:"localhost"
</virtualserver>

4 changes: 4 additions & 0 deletions bin/xlight3.9.5/ftpd.option
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
ShowServiceIcon:yes
RemoteAdminIPPort:"0.0.0.0:0"
LogCommandType:"both"
EnableAutoConfigBackup:yes
4 changes: 4 additions & 0 deletions bin/xlight3.9.5/ftpd.password
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
<virtualserver 127.0.0.1:21>
anonymous:00000000000000000000000000000000
</virtualserver>

1 change: 1 addition & 0 deletions bin/xlight3.9.5/ftpd.rules
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@

9 changes: 9 additions & 0 deletions bin/xlight3.9.5/ftpd.users
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
<virtualserver 127.0.0.1:21>

<username "anonymous">
AllowNoPassword:yes
VirtualPath: "/|e:\Bearsampp-development\sandbox\www\|R--L---S"
Comment on lines +4 to +5

@qodo-code-review qodo-code-review Bot Aug 10, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remediation recommended

2. Nonportable anonymous ftp config 🐞 Bug ⛨ Security

The shipped 3.9.5 FTP configuration enables an anonymous/no-password user and sets its VirtualPath
to an absolute developer machine path (e:\Bearsampp-development\...), which will typically not
exist on user machines and can result in a broken FTP root (security risk increases if the server
bind address is later widened beyond localhost).
Agent Prompt 
### Issue description
The new `bin/xlight3.9.5` configuration ships an anonymous account with `AllowNoPassword:yes` and a hardcoded absolute VirtualPath pointing to a developer-local directory. This is non-portable and can lead to incorrect runtime behavior.

### Issue Context
The Gradle release build copies `bin/<version>/` config files into the packaged output as-is (no templating/substitution visible in this repo), so these defaults are what users receive.

### Fix Focus Areas
- bin/xlight3.9.5/ftpd.users[3-6]
- bin/xlight3.9.5/ftpd.password[1-3]
- bin/xlight3.9.5/ftpd.hosts[1-4]
- build.gradle[744-749]

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

</username>

</virtualserver>

2 changes: 1 addition & 1 deletion build.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
bundle.name = xlight
bundle.release = 2025.7.31
bundle.release = 2026.8.9
bundle.type = bins
bundle.format = 7z

Expand Down