chore(release): npm packages to 0.10.0 - #376
Merged
Merged
Conversation
Both packages, not only the one that changed: npm-publish.yml runs a matrix over @callora/surface and @callora/admin and checks each one's version against the tag. A v0.10.0 tag with surface still on 0.9.0 fails that job — after building, with a message that names the mismatch but not why only one package moved. Minor rather than patch: @callora/admin gained a public function (t), and a patch that adds API is the kind of version number that makes a consumer's caret range mean something other than what they read. This is the version number a release would carry; the tag itself is a separate decision, and a v* tag also runs release.yml over the NuGet packages.
ADMIN_PACKAGE_VERSION is what a plugin compares against to refuse an incompatible host, and it sits in the source as a literal. Bumping package.json without it would have shipped 0.10.0 announcing itself as 0.9.0 — a plugin built for the new contract would then refuse a host that has it. The test that caught this asserts the two agree, which is exactly what it is for.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Preparation for the release that carries
t()to plugins (#375). Without it,@callora/adminon npm stays at 0.9.0 and no plugin can import the function that is already inmain.Why both packages
npm-publish.ymlruns a matrix over@callora/surfaceand@callora/adminand checks each one's version against the tag. Av0.10.0tag with surface still on 0.9.0 fails that job — after building, with a message that names the mismatch but not why only one package moved.Why minor, not patch
@callora/admingained a public function. A patch release that adds API is the kind of version number that makes a consumer's caret range mean something other than what they read.What is verified, and what is not
The plugin half of the snippet chain is proven end to end on the dev stack: after rebuilding the PBX and restarting the host,
snippet_baseholds 19 keys per language for pluginIdpbx, read out of the plugin'sregistry.json. The/api/snippetsendpoint answers 401 unauthenticated, so route and auth are in place; the resolver behind it is existing, covered host code.What is not verified is the last step, because it cannot be until this ships: a plugin importing
tfrom@callora/adminand rendering a translated label.The tag is a separate decision
A
v*tag also runsrelease.ymlover the NuGet packages, so this is a platform release rather than a package bump. The number here is what such a release would carry — change it if you want a different one before tagging.