Fix library version when used as a CMake subproject - #1188
Open
ktyang512 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1119.
Problem
BTCPP_LIBRARY_VERSIONusedCMAKE_PROJECT_VERSION, which is the top-levelproject version. When BehaviorTree.CPP was added with
add_subdirectory()orFetchContent, the library could therefore report the parent project's version.Change
Use BehaviorTree.CPP's directory-scoped
PROJECT_VERSIONand add a CMakeregression that configures the library below a parent project with a different
version.
Validation
BTCPP_LIBRARY_VERSION="9.8.7".BTCPP_LIBRARY_VERSION="4.10.0".pre-commit run -a --show-diff-on-failurepasses../run_clang_tidy.sh build-docker-clang21-cipasses in an Ubuntu 24.04Docker container with
clangd-2121.1.8.