feat(genre-tree): grey out and skip unplayable YouTube tracks - #193
Merged
Merged
Conversation
… playback Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
grow's player hit YouTube error 150 (embedding disabled). Unplayable YouTube tracks are now flagged from end to end instead of being dropped. They stay listed but greyed out with the reason, can't be played, and auto-advance skips them. A video that fails at runtime shows the error and the player moves on to the next track.
Changes
YoutubeTrackDetailedSchemagainsyoutubeUnplayableReason, which is nullable, uses thenot_found | not_embeddable | private | not_processed | region_whitelistedenum, and defaults tonullwhen an older API leaves the key out. The newunplayableReasonLabel(track)returns the display label ornull.opacity-50, shows the reason as small text and atitle, and has adisabled/aria-disabledplay button with noonClick.playNewTrackListFromGenrePlayliststarts at the first playable track at or afterstartIndex.YoutubePlayerTrack.unplayableReason.handleNextTrack/handlePreviousTrackskip tracks that set it. YouTubeonErrorsetsloadError(100 "Video not found"; 101/150 "Embedding disabled by the video owner"; otherwise "YouTube playback error (code N)"), stops playback and firesonTrackEnd. This replaces the oldconsole.error.Consumers must map
youtubeUnplayableReasontoPlayerTrack.unplayableReasonin theirtoPlayerTrackfor the next/previous skip to apply.Test plan
pnpm lint(tsc)pnpm test: 618 tests pass and coverage thresholds are met. New tests cover the schema default and enum, the label helper, greyed rows in both lists, the start-index skip, next/previous skip, and the onError messages plus advance.pnpm build🤖 Generated with Claude Code