AP-815 Change Login Links to Buttons - #107
Conversation
awilfox
left a comment
awilfox
left a comment
There was a problem hiding this comment.
r+wc - two minor fixes, and are we sure we need to have the sidebar-btn render as a link as well?
| .sidebar-buttons .authentication .card-header form.button_to { | ||
| display: inline; | ||
|
|
||
| button.sidebar-btn { | ||
| color: $link-color; | ||
| background-color: transparent; | ||
| cursor: pointer; | ||
|
|
||
| &:hover { | ||
| color: #004e9f; |
There was a problem hiding this comment.
see above regarding whether this is appropriate or not. It's the correct styling, if it is.
There was a problem hiding this comment.
@anarchivist's comment in the other thread seemed to imply this should be backed out.
anarchivist
left a comment
anarchivist
left a comment
There was a problem hiding this comment.
r+wc; just an additional clarification to one of @awilfox's comments.
Co-authored-by: Anna Wilcox <AWilcox@Wilcox-Tech.com>
Co-authored-by: Anna Wilcox <AWilcox@Wilcox-Tech.com>
awilfox
left a comment
awilfox
left a comment
There was a problem hiding this comment.
r+wc - I think we're good after returning the sidebar login button to a button style.
| .sidebar-buttons .authentication .card-header form.button_to { | ||
| display: inline; | ||
|
|
||
| button.sidebar-btn { | ||
| color: $link-color; | ||
| background-color: transparent; | ||
| cursor: pointer; | ||
|
|
||
| &:hover { | ||
| color: #004e9f; |
There was a problem hiding this comment.
@anarchivist's comment in the other thread seemed to imply this should be backed out.
3 participants
Since the login links in the header nav and the restricted tool sidebar actually trigger POST requests, they've been updated to be buttons.