Conversation
anarchivist
left a comment
There was a problem hiding this comment.
i have some questions about the javascript. i can't get the download function (nor the metadata display in the modal) to work with ISO 19139 metadata.
| pin '@github/auto-complete-element', to: 'https://cdn.skypack.dev/@github/auto-complete-element' | ||
| pin '@popperjs/core', to: 'https://ga.jspm.io/npm:@popperjs/core@2.11.6/dist/esm/popper.js' | ||
| pin 'bootstrap', to: 'https://ga.jspm.io/npm:bootstrap@5.3.2/dist/js/bootstrap.esm.js' | ||
| pin 'geoblacklight/initializers/metadata_download', to: 'geoblacklight/initializers/metadata_download.js' |
There was a problem hiding this comment.
is this adequate to pull in all the dependencies needed by geoblacklight?
There was a problem hiding this comment.
The metadata link is not displayed when a record does not include ISO 19139 metadata.
The default Solr sample records from GeoBlacklight are outdated. Most records either lack metadata or contain incorrectly formatted ISO metadata. As a result, the metadata link may not appear, or the metadata modal may display incorrect ISO information.
I ingested a record with valid ISO 19139 metadata from GeoCombine, which allows me to properly test the metadata modal and its buttons locally.
There was a problem hiding this comment.
can you give me an example record? i'm going based on the fixture data that is used for testing.
There was a problem hiding this comment.
is this intended to be different from the initializer javascript shipped with GeoBlacklight 5.3.0? why do we need to override it?
The download button which opens metadata in a new browser window, in the GeoBlacklight metadata modal is not working.
Update the related script from Geoblacklight to restore the download functionality, support multiple metadata standards in separate tabs, and ensure each button opens the corresponding metadata in a new window.