Fix PDC_wcstombs() for an output that exactly fills the buffer - #391
Open
serhiy-storchaka wants to merge 1 commit into
Open
serhiy-storchaka wants to merge 1 commit into
serhiy-storchaka wants to merge 1 commit into
Conversation
wcstombs() returns n when the converted string fills all n bytes; that is not an error. Also compare the result with (size_t)-1 instead of casting it to int. Fixes Bill-Gray#390.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
wcstombs()returnsnwhen the converted string fills allnbytes; that is a complete conversion, not an error, so terminate atdest[n]as before ea9baa4 instead of zeroing*dest. Also detect the failure asi == (size_t)-1rather than by casting asize_ttoint.With the
vtport:PDC_wcstombs(buf, L"ABCDE", 5)gave"\0BCDE"(and fails the assert in a build with assertions); it now gives"ABCDE", and an unencodable input still returns(size_t)-1with an emptydest.Fixes #390.