Skip to content

Fixes the excessive memory usage described in GH-47 #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gioyous-it wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Fixes the excessive memory usage described in GH-47 #48

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
80393fc
Fixes the excessive memory usage described in [GH-47](https://github.…
gioyous-it Aug 28, 2026
f507584
Update copyright year and format license comment
gioyous-it Aug 28, 2026
fa0e943
Update UnihexFontType.kt
gioyous-it Aug 28, 2026
3fce6c9
Fix formatting and improve comments in UnihexFontType.kt
gioyous-it Aug 28, 2026
de45d29
Refactor UnihexFontType.kt for improved readability
gioyous-it Aug 28, 2026
fcb77a0
Remove unused methods and clean up UnihexFontType
gioyous-it Aug 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions src/main/java/de/bixilon/minosoft/gui/rendering/font/types/unicode/unihex/UnihexFontType.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
/*
* Minosoft
* Copyright (C) 2020-2025 Moritz Zwerger
* Copyright (C) 2020-2026 Moritz Zwerger
*
* This program is free software: you can redistribute it and/or modify it under the terms of the GNU General Public License as published by the Free Software Foundation, either version 3 of the License, or (at your option) any later version.
*
Expand Down Expand Up @@ -126,9 +126,10 @@ class UnihexFontType(
while (this.available() > 0) {
val codePoint = readHexInt()
if (codePoint == -1) continue
val data = this.readUnihexData(buffer)
chars[codePoint] = data
totalWidth += data.size / (UnifontRasterizer.HEIGHT / Byte.SIZE_BITS)
val data = readUnihexData(buffer)
if (chars.putIfAbsent(codePoint, data) == null) {
totalWidth += data.size / (UnifontRasterizer.HEIGHT / Byte.SIZE_BITS)
}
}

return totalWidth
Expand Down
Loading