fix(cancelPage): reword completion/cancel text + clear stale reason on new print - #314
Open
gmmcosta15 wants to merge 17 commits into
Open
fix(cancelPage): reword completion/cancel text + clear stale reason on new print#314gmmcosta15 wants to merge 17 commits into
gmmcosta15 wants to merge 17 commits into
Conversation
…ensor_state signal
…cationPage; fix KeyError on missing result key, None emit crash on gcode params, dead installEventFilter call, and source unbound annotation
…tion/cancel messages
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces:
_REASON_HEADERS: "complete" → "Print Finished", "cancelled" → "Print Canceled"cf_info_tfonprintingstate so stale reason text from a prior cycle can't leak throughMotivation
CancelPage text could persist across print cycles if a new print didn't end via a state in
_REASON_HEADERS.