Skip to content

chore(resources): rename assets to English snake_case, prune dead SVGs - #328

Closed
gmmcosta15 wants to merge 17 commits into
devfrom
refactor/resource-layout
Closed

chore(resources): rename assets to English snake_case, prune dead SVGs#328
gmmcosta15 wants to merge 17 commits into
devfrom
refactor/resource-layout

Conversation

@gmmcosta15

@gmmcosta15 gmmcosta15 commented Sep 3, 2026

Copy link
Copy Markdown
Collaborator

Description

  • Code refactor

Cleans up lib/ui/resources: consistent English snake_case filenames and prunes dead weight, enabled by the BlocksPixmap/Icon enum (#316-#327) making renames a 3-place edit instead of a repo-wide literal hunt.

  • Deleted 59 dead SVGs (50 fully orphaned, 3 qrc-declared but unused, 6 caught by the new guard test)
  • Renamed 24 assets: spaces, typos, casing, hyphens/_icon suffixes, non-English name, leading-digit wifi files
  • Added test_no_orphan_assets_on_disk guard test to catch this drift going forward

Motivation

Prior PRs left dead/inconsistently-named assets undetected (no reverse check existed). This is the deferred cleanup pass, done last so it wouldn't conflict with the stack.

@gmmcosta15
gmmcosta15 marked this pull request as draft September 3, 2026 09:50
@gmmcosta15 gmmcosta15 closed this Sep 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant