Skip to content

Add security headers #833

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
w00000dy wants to merge 1 commit into
base: master
Choose a base branch
from
+8 −5
Open

Add security headers #833

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions common/src/main/java/de/bluecolored/bluemap/common/plugin/Plugin.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -241,7 +241,7 @@ private void load(@Nullable ResourcePack preloadedResourcePack) throws IOExcepti
webRequestHandler.register(
"maps/" + Pattern.quote(id) + "/(.*)",
"$1",
new BlueMapResponseModifier(mapRequestHandler)
mapRequestHandler
);
}

Expand All @@ -260,7 +260,7 @@ private void load(@Nullable ResourcePack preloadedResourcePack) throws IOExcepti
webServer = new HttpServer(
"BlueMap-Webserver",
new LoggingRequestHandler(
webRequestHandler,
new BlueMapResponseModifier(webRequestHandler),
webserverConfig.getLog().getFormat(),
webLogger
)
Expand Down
9 changes: 6 additions & 3 deletions common/src/main/java/de/bluecolored/bluemap/common/web/BlueMapResponseModifier.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,6 @@
import de.bluecolored.bluemap.common.web.http.HttpRequestHandler;
import de.bluecolored.bluemap.common.web.http.HttpResponse;
import de.bluecolored.bluemap.common.web.http.HttpStatusCode;
import de.bluecolored.bluemap.core.BlueMap;
import lombok.Getter;
import lombok.NonNull;
import lombok.Setter;
Expand All @@ -41,7 +40,6 @@ public class BlueMapResponseModifier implements HttpRequestHandler {

public BlueMapResponseModifier(HttpRequestHandler delegate) {
this.delegate = delegate;
this.serverName = "BlueMap/" + BlueMap.VERSION;
}

@Override
Expand All @@ -53,7 +51,12 @@ public HttpResponse handle(HttpRequest request) {
response.setBody(status.getCode() + " - " + status.getMessage() + "\n" + this.serverName);
}

response.addHeader("Server", this.serverName);
response.addHeader("Server", "BlueMap");
response.addHeader("Content-Security-Policy", "default-src 'self'; script-src 'self' 'unsafe-inline' 'unsafe-eval'; style-src 'self' 'unsafe-inline'; img-src 'self' data: blob: https:; object-src 'none';");
response.addHeader("X-Frame-Options", "SAMEORIGIN");
response.addHeader("X-Content-Type-Options", "nosniff");
response.addHeader("Referrer-Policy", "strict-origin-when-cross-origin");
response.addHeader("Permissions-Policy", "accelerometer=(), ambient-light-sensor=(), autoplay=(), battery=(), camera=(), cross-origin-isolated=(), display-capture=(), document-domain=(), encrypted-media=(), execution-while-not-rendered=(), execution-while-out-of-viewport=(), fullscreen=(self), geolocation=(), gyroscope=(), keyboard-map=(), magnetometer=(), microphone=(), midi=(), navigation-override=(), payment=(), picture-in-picture=(), publickey-credentials-get=(), screen-wake-lock=(self), sync-xhr=(), usb=(), web-share=(), xr-spatial-tracking=()");

return response;
}
Expand Down