fix: title screen particle burst effect never working correctly - #96
Open
camping6464 wants to merge 2 commits into
Open
camping6464 wants to merge 2 commits into
camping6464 wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
effects.rpy
Using the animation timebase for the
SpriteManagerinParticleBurstcauses the particles to always despawn prematurely, one frame after being generated. Setting theanimationparameter toFalsein theSpriteManager()initialization fixes the issue by giving it its own timer that starts at 0 instead of relying on the timer from theimageortransformanimation that calls the SpriteManager.splash.rpy
The particle burst effect always play again each time the user re-enters the title screen, even from another screen of the main menu. Moving the
ParticleBurst().smcall out ofimage menu_particlesand insidetransform emit_particles(formerly known astransform particle_fadeout) fixes the issue and makes the effect play only once as long as the user is still in a screen part of the main menu, similarly totransform menu_art_move().The
pausetimer fromimage menu_particleshas also been moved totransform emit_particlesto potentially avoid unnecessary uses of an animation pause timer when nothing is supposed to happen afterwards.