Automatically set AMBERHOME so Amber executables produce output files - #145
Merged
Merged
Conversation
Collaborator
Coverage Report for CI Build 36761563662Coverage increased (+24.4%) to 81.405%Details
Uncovered ChangesNo uncovered changes found. Coverage Regressions5 previously-covered lines in 1 file lost coverage.
Coverage Stats
💛 - Coveralls |
harryswift01
approved these changes
Oct 1, 2026
harryswift01
left a comment
Member
There was a problem hiding this comment.
This looks like a good fix that will ensure that the aiida_* executables can locate their AMBERHOME data files and reliably produce output. Happy to see this merged in.
AMBERHOME so Amber executables produce output files
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR updates the way AmberTools executables are configured and tested in both the main code and the tests. The main improvement is that the
AMBERHOMEenvironment variable is now set automatically based on the location of each Amber executable. This results inaiida_*executables and tests run locally to now return outputs/pass.AmberTools environment configuration:
aiida_amber/helpers.py, theget_codefunction now sets theAMBERHOMEenvironment variable automatically.Test fixtures improvements:
conftest.py, all code fixtures for AmberTools executables (sander,tleap,antechamber,pdb4amber,parmed) now:shutil.whichto determine the absolute path to each executable.AMBERHOMEenvironment variable dynamically for each fixture, mirroring the change in the main code.Impact