Skip to content

packages/build: follow-ups from the three review rounds of #11 #16

Description

@cverorg

Non-blocking findings left after #11 merged (three adversarial rounds; the reviews live with the maintainer). Round 3:

R3-1 detached: true 讓「關掉終端機」不再打得到 astro——孤兒活著並寫進站主的 --outDir
R3-2 中止的 build 在 renderer 裡留下 769KB 的 astro 暫存,其中一份含站主的頁面全文;leftovers() 看不見它
R3-3 restore 自己壞掉時,exit code 跟乾淨中斷一模一樣
R3-4 最後那一發 SIGKILL 少了 signalChild 自己有的守衛
R3-5 兩處交叉引用指向一個已經改名的段落
R3-6 「Aborting unwinds the build」對 stageSite 只在 staging 期間為真
R3-7 killGraceMs 預設 5000 是 docker stop 預設寬限的一半
R3-8 AbortError 沒有帶 signal.reason
R3-9 private: truebincli.mjs100644

Round 2, non-blocking:

Also from round 1: P3-13 unknown CLI flags are silently ignored (--siteurl typo → every canonical wrong, no message) — cheapest and most painful of the P3s; P3-14, P3-15. R3-2 (an aborted build leaves astro's temp dir, one copy containing the owner's page text, and leftovers() cannot see it) should go first.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions