Skip to content

fix: 릴리즈 리뷰 반영 (특별휴무일 픽업 슬롯 빈 배열 반환) - #195

Merged
chanwoo7 merged 1 commit into
developfrom
fix/release-review-store-pickup-closure-slots
Aug 22, 2026
Merged

fix: 릴리즈 리뷰 반영 (특별휴무일 픽업 슬롯 빈 배열 반환)#195
chanwoo7 merged 1 commit into
developfrom
fix/release-review-store-pickup-closure-slots

Conversation

@chanwoo7

Copy link
Copy Markdown
Member

배경

릴리즈 PR #194의 CodeRabbit 지적 반영입니다.
SDL 주석은 "영업하지 않는 날은 빈 배열"인데, 특별휴무일은 요일 휴무와 달리 전체 슬롯을 available: false로 반환해 동작이 어긋났습니다.
특별휴무도 "매장이 그날 안 여는 날"이므로 요일 휴무와 동일하게 빈 배열로 통일합니다.

변경점

  • storePickupTimeSlots: 특별휴무일이면 슬롯 생성 전에 빈 배열 반환.
  • PAST/OUT_OF_RANGE/CAPACITY_FULL/당일 리드타임 마감은 영업일이므로 기존대로 슬롯 마감 표기 유지.

검증

  • real DB 회귀 테스트 1건 추가(특별휴무일 빈 배열), 스위트 19건 전체 통과.

릴리즈 PR #194 CodeRabbit 지적 반영. SDL 주석은 "영업하지 않는 날은
빈 배열"인데 특별휴무일은 요일 휴무와 달리 전체 슬롯을 available=false로
반환해 동작이 어긋났다.

- storePickupTimeSlots: 특별휴무일도 요일 휴무와 동일하게 빈 배열 반환
- PAST/OUT_OF_RANGE/CAPACITY_FULL/당일 마감은 영업일이므로 기존대로
  슬롯을 마감 표기로 유지
- 회귀 테스트 1건 추가 (특별휴무일 빈 배열)
@coderabbitai

coderabbitai Bot commented Aug 22, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 1c0f8181-dd84-4321-9f8d-6d852e5e4092

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

Copy link
Copy Markdown

🩺 NestJS Doctor — 89/100 (Good)

진단 279건 (error 0).

Category error warning info
architecture 0 0 13
correctness 0 126 0
performance 0 24 17
schema 0 0 86
security 0 13 0
architecture / security 상위 항목
  • info architecture/architecture/no-barrel-export-internals: Barrel file re-exports internal type 'IAuditLogRepository'.
  • warning security/security/no-exposed-env-vars: Direct 'process.env.NODE_ENV' access in 'AuthController'. Use ConfigService instead.
  • warning security/security/require-guards-on-endpoints: Endpoint 'start' has no @UseGuards() at class or method level.
  • warning security/security/require-guards-on-endpoints: Endpoint 'callback' has no @UseGuards() at class or method level.
  • warning security/security/require-guards-on-endpoints: Endpoint 'refresh' has no @UseGuards() at class or method level.
  • warning security/security/require-guards-on-endpoints: Endpoint 'logout' has no @UseGuards() at class or method level.
  • warning security/security/require-guards-on-endpoints: Endpoint 'sellerLogin' has no @UseGuards() at class or method level.
  • warning security/security/require-guards-on-endpoints: Endpoint 'sellerRefresh' has no @UseGuards() at class or method level.
  • warning security/security/require-guards-on-endpoints: Endpoint 'sellerLogout' has no @UseGuards() at class or method level.
  • warning security/security/require-guards-on-endpoints: Endpoint 'devIssueToken' has no @UseGuards() at class or method level.
  • info architecture/architecture/no-barrel-export-internals: Barrel file re-exports internal module '@/features/conversation/repositories/conversation.repository'.
  • info architecture/architecture/no-barrel-export-internals: Barrel file re-exports internal type 'ConversationRepository'.
  • info architecture/architecture/no-barrel-export-internals: Barrel file re-exports internal module '@/features/order/repositories/order.repository'.
  • info architecture/architecture/no-barrel-export-internals: Barrel file re-exports internal type 'OrderRepository'.
  • info architecture/architecture/no-barrel-export-internals: Barrel file re-exports internal module '@/features/product/repositories/product.repository'.

오탐 포함 가능 · 기준 docs/guide/architecture-conventions.md

@github-actions

Copy link
Copy Markdown

🧹 knip — dead-code 리포트

요약 항목 없음
전체 리포트
(knip 출력 없음 — 이슈 0이거나 실행 실패)

청소 후보(오탐 가능) · 기준 docs/guide/architecture-conventions.md

@codecov

codecov Bot commented Aug 22, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@github-actions

Copy link
Copy Markdown

Coverage report

St.
Category Percentage Covered / Total
🟢 Statements 97.61% 4770/4887
🟢 Branches 93.28% 1526/1636
🟢 Functions 95.99% 933/972
🟢 Lines 98.21% 4337/4416

Test suite run success

1573 tests passing in 184 suites.

Report generated by 🧪jest coverage report action from 21df412

@chanwoo7
chanwoo7 merged commit 03c936e into develop Aug 22, 2026
12 checks passed
@chanwoo7
chanwoo7 deleted the fix/release-review-store-pickup-closure-slots branch August 22, 2026 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant