fix(billing): prevent duplicate refunds during provider retries and concurrent submissions - #1194
Merged
greatest0fallt1me merged 1 commit intoAug 29, 2026
Conversation
…oncurrent submissions
|
@VerifiedFlemzy1 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1167
Summary
Resolves duplicate refund application issues caused by provider retries, network replays, or concurrent client submissions sharing the same
Idempotency-Key.Changes Made
idempotencyMiddlewareinsrc/middleware/idempotency.tsto perform atomicINSERT ... ON CONFLICT (idempotency_key) DO NOTHING. If a concurrent request is already inserting the key, the subsequent execution detects the record and handles it safely without racing.Idempotent-Replayed: true.prevents duplicate refunds on concurrent retries with the same Idempotency-Keyinsrc/routes/billing/refund.test.tsto assert that developer balances are only credited once under concurrent submissions.Verification
npx jest src/middleware/idempotency.test.ts(27/27 passed)npx jest src/routes/billing/refund.test.ts(9/9 passed)