feat: Verify migration rollback contracts against current schema - #1198
Merged
greatest0fallt1me merged 1 commit intoAug 29, 2026
Merged
Conversation
Closes #xyz (Implement Verify migration rollback contracts) - Extracted applyMigrations and validateSchemaState in src/migrate.ts - Updated src/db/index.ts to validate expected schema/state before app work proceeds - Added deterministic test suite in src/migrations.test.ts to verify rollback boundaries and ensure destructive changes are checked
|
@Devadakene Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1192
Description
Closes #
This PR implements verification of migration rollback contracts and ensures deterministic checking of boundaries without destructive transformation. It updates the initial application startup logic to validate the state of the schema deterministically.
Key Changes
Migration Application (
src/migrate.ts):applyMigrationsfunction.validateSchemaStatefunction that ensures the app database does not have unapplied schema drifts or unexecuted migrations relative to the.sqlfiles.Initialization Logic (
src/db/index.ts):applyMigrations()andvalidateSchemaState().initializeDb), it will now deterministically apply or validate the expected layout, fulfilling the fresh-install and upgrade-paths criteria.Automated Rolling Verification (
src/migrations.test.ts):Migration Rollback Contracts) using an in-memory db.UP, then runsDOWN(if the rollback script is present), and verifies that thesqlite_mastermetadata reverts identically to the pre-migration state.UPmigration to proceed up the sequence, ensuring ordering, compatibility, and rollback boundaries are correct and strictly valid for the codebase.Verification Checklist