Firefly-2087: Refactor SuggestBoxInputField to Use a Functional Component - #2004
Open
aventura121 wants to merge 9 commits into
Open
Firefly-2087: Refactor SuggestBoxInputField to Use a Functional Component#2004aventura121 wants to merge 9 commits into
aventura121 wants to merge 9 commits into
Conversation
The component-library storybook build currently fails on an unrelated circular-import fault in ChartPanel, so this story cannot be rendered or verified. Re-add once that is fixed. The index.js exports stay, since they are the published package surface, not storybook.
aventura121
changed the title
aventura121
changed the title
aventura121
marked this pull request as ready for review
September 4, 2026 20:51
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Firefly-2087: Refactor SuggestBoxInputField to Use a Functional Component
Description
This PR removes all of the callers to SuggestBoxInput to the Joy UI component, AutoComplete/AutoCompleteView.
Companion PR in irsa-ife (to be merged after): https://github.com/IPAC-SW/irsa-ife/pull/477
Testing
Firefly build: https://firefly-2087-use-joy-autocomplete-all.irsakubedev.ipac.caltech.edu/firefly
Irsa-ife-sha build (SHA needs changes related to this PR): https://firefly-2087-use-joy-autocomplete-all.irsakubedev.ipac.caltech.edu/applications/Spitzer/SHA
Irsa-ife-wise build (wise has no irsa-ife specifc code paths related to this PR): https://firefly-2087-use-joy-autocomplete-all.irsakubedev.ipac.caltech.edu/applications/wise
For firefly:
Screenshot
For irsa-ife-sha (contains irsa-ife specific code changes):
Screenshot
For irsa-ife-wise:
Screenshot