fix(desktop): clear overlay restore label on recording mode switch - #2098
Open
wizlor-bfw wants to merge 1 commit into
Open
fix(desktop): clear overlay restore label on recording mode switch#2098wizlor-bfw wants to merge 1 commit into
wizlor-bfw wants to merge 1 commit into
Conversation
Switching recording mode while a "restore this overlay when Settings closes" instruction is pending left it stale, so the target-select overlay could pop back up as a screen-wide input-eating surface after the user had already moved to a different mode. Fixes CapSoftware#1945. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01QGraCJTpXDy24K5g3wwfhD
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Switching recording mode while a "restore this overlay when Settings closes" instruction is pending left it stale, so the target-select overlay could pop back up as a screen-wide input-eating surface after the user had already moved to a different mode. Fixes #1945.
Verified with
cargo fmt --all. Wasn't able to fully build the nativedeps (FFmpeg/whisper.cpp) in my dev environment to run
cargo checkend-to-end — happy to iterate if CI or a maintainer spots anything.
Greptile Summary
This PR clears pending target-select overlay restoration labels whenever the recording mode changes, preventing Settings from reopening an overlay that belongs to the previous mode.
Managertrait to access managed window-focus state.Confidence Score: 5/5
The PR appears safe to merge, with the pending overlay restoration state cleared at the intended recording-mode transition.
The managed focus state is registered during application setup, and clearing its restoration labels after mode persistence prevents Settings-close handling from reviving an overlay associated with the previous mode.
Important Files Changed
Reviews (1): Last reviewed commit: "fix(desktop): clear overlay restore labe..." | Re-trigger Greptile
Context used: