Skip to content

fix(desktop): clear overlay restore label on recording mode switch - #2098

Open
wizlor-bfw wants to merge 1 commit into
CapSoftware:mainfrom
wizlor-bfw:fix-1945-overlay-freeze
Open

fix(desktop): clear overlay restore label on recording mode switch#2098
wizlor-bfw wants to merge 1 commit into
CapSoftware:mainfrom
wizlor-bfw:fix-1945-overlay-freeze

Conversation

@wizlor-bfw

@wizlor-bfw wizlor-bfw commented Aug 7, 2026

Copy link
Copy Markdown

Switching recording mode while a "restore this overlay when Settings closes" instruction is pending left it stale, so the target-select overlay could pop back up as a screen-wide input-eating surface after the user had already moved to a different mode. Fixes #1945.

Verified with cargo fmt --all. Wasn't able to fully build the native
deps (FFmpeg/whisper.cpp) in my dev environment to run cargo check
end-to-end — happy to iterate if CI or a maintainer spots anything.

Greptile Summary

This PR clears pending target-select overlay restoration labels whenever the recording mode changes, preventing Settings from reopening an overlay that belongs to the previous mode.

  • Imports Tauri’s Manager trait to access managed window-focus state.
  • Clears pending overlay restore labels after successfully persisting the new mode and updating the tray icon.

Confidence Score: 5/5

The PR appears safe to merge, with the pending overlay restoration state cleared at the intended recording-mode transition.

The managed focus state is registered during application setup, and clearing its restoration labels after mode persistence prevents Settings-close handling from reviving an overlay associated with the previous mode.

Important Files Changed

Filename Overview
apps/desktop/src-tauri/src/recording_settings.rs The recording-mode command now invalidates stale overlay restoration state after a successful mode change; no actionable defect was identified.

Reviews (1): Last reviewed commit: "fix(desktop): clear overlay restore labe..." | Re-trigger Greptile

Context used:

Switching recording mode while a "restore this overlay when Settings
closes" instruction is pending left it stale, so the target-select
overlay could pop back up as a screen-wide input-eating surface after
the user had already moved to a different mode. Fixes CapSoftware#1945.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01QGraCJTpXDy24K5g3wwfhD
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

UI Freeze: Area selection overlay triggers unexpectedly and locks the screen when exiting Settings in Instant Mode

1 participant