Skip to content

fix(Loaders): use valid 0% keyframe selector for horizontal-circle animations - #1187

Open
nihaocami wants to merge 1 commit into
ClickHouse:mainfrom
nihaocami:fix/loaders-invalid-keyframe-selector
Open

fix(Loaders): use valid 0% keyframe selector for horizontal-circle animations#1187
nihaocami wants to merge 1 commit into
ClickHouse:mainfrom
nihaocami:fix/loaders-invalid-keyframe-selector

Conversation

@nihaocami

@nihaocami nihaocami commented Sep 7, 2026

Copy link
Copy Markdown

Why?

While experimenting with CUI, I ran into some warning at build time that seems to be coming from this changed file.

The Error:

▲ [WARNING] Expected percentage but found "0" [css-syntax-error]

    <stdin>:810:2:
      810 │   0 {
          ╵   ^

How?

  • Replace the wrong keyframe percentage value from 0 to 0%

@changeset-bot

changeset-bot Bot commented Sep 7, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 23325af

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@clickhouse/click-ui Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@CLAassistant

CLAassistant commented Sep 7, 2026

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@XOP XOP added the bug Something isn't working label Sep 8, 2026
@XOP
XOP requested review from DreaminDani and a lite review from Copilot September 8, 2026 08:24

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The change is minimal, correct (CSS-valid 0% keyframes), and aligns with the PR’s stated goal of eliminating the build-time css-syntax warning.

Pull request overview

Fixes a CSS syntax warning in the loaders icon CSS module by correcting invalid keyframe selectors so the horizontal-circle SVG animations are parsed consistently.

Changes:

  • Updated @keyframes loaders-horizontal-circle-{1,2,3} to use 0% instead of the invalid unitless 0 selector.
  • Added a patch changeset documenting the fix and why it matters (prevents the initial keyframe from being dropped by stricter parsers).
File summaries
File Description
src/components/Assets/Icons/Loaders.module.css Replaces invalid 0 { keyframe selectors with valid 0% { for three horizontal-circle animations.
.changeset/fix-loaders-invalid-keyframe-selector.md Adds a patch changeset describing the keyframe selector fix and its impact.
Review details
  • Files reviewed: 2/2 changed files
  • Comments generated: 0
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@XOP

XOP commented Sep 8, 2026

Copy link
Copy Markdown
Collaborator

Thank for the contribution @nihaocami 👍

@XOP
XOP self-requested a review September 8, 2026 09:16

@XOP XOP left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants