fix(Loaders): use valid 0% keyframe selector for horizontal-circle animations - #1187
Open
nihaocami wants to merge 1 commit into
Open
fix(Loaders): use valid 0% keyframe selector for horizontal-circle animations#1187nihaocami wants to merge 1 commit into
nihaocami wants to merge 1 commit into
Conversation
🦋 Changeset detectedLatest commit: 23325af The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The change is minimal, correct (CSS-valid 0% keyframes), and aligns with the PR’s stated goal of eliminating the build-time css-syntax warning.
Pull request overview
Fixes a CSS syntax warning in the loaders icon CSS module by correcting invalid keyframe selectors so the horizontal-circle SVG animations are parsed consistently.
Changes:
- Updated
@keyframes loaders-horizontal-circle-{1,2,3}to use0%instead of the invalid unitless0selector. - Added a patch changeset documenting the fix and why it matters (prevents the initial keyframe from being dropped by stricter parsers).
File summaries
| File | Description |
|---|---|
| src/components/Assets/Icons/Loaders.module.css | Replaces invalid 0 { keyframe selectors with valid 0% { for three horizontal-circle animations. |
| .changeset/fix-loaders-invalid-keyframe-selector.md | Adds a patch changeset describing the keyframe selector fix and its impact. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Collaborator
|
Thank for the contribution @nihaocami 👍 |
XOP
self-requested a review
September 8, 2026 09:16
DreaminDani
approved these changes
Sep 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why?
While experimenting with CUI, I ran into some warning at build time that seems to be coming from this changed file.
The Error:
How?
0to0%