CP-47356: Build on Go 1.26.7 to clear stdlib CVEs - #1001
Open
evan-cz wants to merge 1 commit into
Open
Conversation
Greptile SummaryThe PR synchronizes the repository’s Go toolchain version at 1.26.7 to ensure locally built binaries use the patched standard library.
Confidence Score: 5/5The PR appears safe to merge. No blocking failure remains. Important Files Changed
Reviews (8): Last reviewed commit: "CP-47356: Build on Go 1.26.7 to clear st..." | Re-trigger Greptile |
evan-cz
force-pushed
the
CP-47350-go-1267
branch
from
September 4, 2026 14:38
563d2ce to
05db3f6
Compare
Contributor
Author
|
@greptileai review |
evan-cz
force-pushed
the
CP-47350-go-1267
branch
4 times, most recently
from
September 4, 2026 16:45
e20ba72 to
05db3f6
Compare
amfelso
approved these changes
Sep 4, 2026
Contributor
Author
|
Rebuilding against the re-tagged |
evan-cz
force-pushed
the
CP-47350-go-1267
branch
from
September 4, 2026 18:41
05db3f6 to
42d7332
Compare
Clears six high-severity Go standard library advisories carried by every binary this repository builds. Repinning the bundled Alloy fixes only the binary that comes from elsewhere; the nine agent binaries and prometheus-config-reloader are compiled here, so they keep whatever standard library their build image provides until it moves. The stdlib version baked into a binary comes from the toolchain that built it, so the Dockerfiles are where this takes effect. The go directives move with them because scripts/ci-checks.sh treats the version in go.mod as the single source of truth and requires every Dockerfile and every module to agree, which keeps the toolchain from drifting apart across the four modules and three images. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
evan-cz
force-pushed
the
CP-47350-go-1267
branch
from
September 4, 2026 20:53
42d7332 to
09280a7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #1000 — review and merge that first. (Branch name predates the ticket split and carries the parent key; not worth churning the PR to rename.)
Repinning the bundled Alloy fixes only the binary vendored from elsewhere. The nine agent binaries and
prometheus-config-reloaderare compiled in this repository, so they keep whatever standard library their build image provides until it moves.The stdlib version baked into a binary comes from the toolchain that built it, so the Dockerfiles are where this takes effect. The
godirectives move with them becausescripts/ci-checks.shtreats the version ingo.modas the single source of truth and requires every Dockerfile and every module to agree — which is what keeps the toolchain from drifting apart across the four modules and three images.Seven places, all enforced by that check:
go.mod,.tools/go.mod,tests/go.mod,tests/integration/test_server/go.modgo 1.26.7docker/Dockerfile,tests/docker/Dockerfile.smoke-tests,tests/integration/test_server/Dockerfilegolang:1.26.7Precedent: f0d0829 (1.26.4 to 1.26.5) changed the identical seven files.
Verification.
scripts/ci-checks.shpasses locally (exit 0). This clears the stdlib advisories but not the whole gate on its own — see the rest of the stack.Stack: #1000 (Alloy) → #1001 (this) → #1003 (grype output) → #1004 (reloader)
🤖 Generated with Claude Code