feat: support go 1.26 and 1.27 - #66
Conversation
Hooray! CodSpeed harness just leveled up!The base and head of this comparison were measured with different runner settings, so their benchmark values are not directly comparable. What changed between base and head:
Re-run the base with the same settings to get a valid performance comparison. Comparing |
Add a version-matched benchmark.go overlay for Go 1.26 (identical upstream file in 1.27) and extend the CI test matrix to 1.26.x and 1.27.x.
39a9bca to
93eb80f
Compare
Greptile SummaryAdds Go 1.26 and 1.27 support by introducing an instrumented Go 1.26 benchmark overlay and selecting it for newer toolchains.
Confidence Score: 5/5The PR appears safe to merge with no concrete blocking or non-blocking defects identified. The new overlay follows the existing instrumentation pattern, version selection routes the intended toolchains to it, and the expanded CI matrix exercises actual overlay-backed benchmark execution.
|
| Filename | Overview |
|---|---|
| go-runner/src/runner/overlay/mod.rs | Selects the new Go 1.26 benchmark overlay for Go 1.26 and later while preserving existing selections for older toolchains. |
| go-runner/overlay/benchmark1.26.0.go | Adds the Go 1.26 testing benchmark implementation with the established CodSpeed instrumentation lifecycle. |
| go-runner/overlay/benchmark1.26.0.patch | Records the instrumentation delta from the upstream Go 1.26 benchmark implementation. |
| .github/workflows/ci.yml | Expands the integration-test matrix to Go 1.26.x and 1.27.x. |
Reviews (1): Last reviewed commit: 39a9bca | Re-trigger Greptile
| # This downloads unpatched Go benchmark.go files and diffs them against our patched versions | ||
|
|
||
| SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)" | ||
| VERSIONS=("1.24.0" "1.25.0") |
There was a problem hiding this comment.
Shouldnt we also add 1.27 here?
There was a problem hiding this comment.
If it's just a matter of the patch being the same, wouldnt it be better handled eitehr with a symlink, or a small system that removes the pure coupling between patch file and go version in order for it to be understandable in the future?
Adds a version-matched
benchmark.gooverlay for Go 1.26 (the upstream file is identical in 1.27) and extends the CI test matrix to 1.26.x and 1.27.x.Closes COD-3356