London | 26-Jul-SDC | Roman Sanaye | Sprint 5 | Prep Exercises - #650
Open
RomanSanaye wants to merge 1 commit into
Open
London | 26-Jul-SDC | Roman Sanaye | Sprint 5 | Prep Exercises#650RomanSanaye wants to merge 1 commit into
RomanSanaye wants to merge 1 commit into
Conversation
RomanSanaye
added
the
Needs Review
LonMcGregor
reviewed
Aug 12, 2026
LonMcGregor
left a comment
LonMcGregor
left a comment
Contributor
There was a problem hiding this comment.
Good work on this, lots of good implementations. I have a few comments on some files
Contributor
There was a problem hiding this comment.
Did you mean to commit this file? How could you prevent it from being comitted in future?
Contributor
There was a problem hiding this comment.
Have you tried added the type annotations to this file?
|
|
||
| def is_adult(self): | ||
| today = date.today() | ||
| age = today.year - self.date_of_birth.year |
Contributor
There was a problem hiding this comment.
Will this definitely give the correct age for all possible days?
|
|
||
|
|
||
| people = [ | ||
| Person(name="Imran", age=22, preferred_operating_systems="Ubuntu"), |
Contributor
There was a problem hiding this comment.
I get a mypy warning here, can you figure out why?
| input("What is your preferred operating system? ") | ||
| ) | ||
| except ValueError: | ||
| print("Invalid operating system.", file=sys.stderr) |
Contributor
There was a problem hiding this comment.
Can you think of a more graceful UX for handling invalid inputs?
LonMcGregor
added
Reviewed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Self checklist
Changelist
Added the Sprint 5 preparation exercises, including Python dataclasses, type annotations, enums, inheritance, methods, and type-guided refactoring.
I also tested the exercises using Python and mypy to check the code and type annotations.
Questions