Skip to content

Fix negative streak handling in getFreebuffStreakGlmWeeklyUnits #1261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pavankumar-vh wants to merge 1 commit into
base: main
Choose a base branch
from
+13 −1
Open

Fix negative streak handling in getFreebuffStreakGlmWeeklyUnits #1261

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions common/src/util/__tests__/freebuff-streak.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ import {
calculateFreebuffStreak,
getFreebuffDailyStreakRewardPool,
getFreebuffStreakGlmBonusUnits,
getFreebuffStreakGlmWeeklyUnits,
getFreebuffUsageDateKey,
} from '../freebuff-streak'

Expand Down Expand Up @@ -199,4 +200,14 @@ describe('freebuff streak rewards', () => {
}),
).toBeNull()
})

test('getFreebuffStreakGlmWeeklyUnits clamps negative streaks to zero', () => {
// Negative streak values would produce negative bonus units without the clamp.
expect(getFreebuffStreakGlmWeeklyUnits(-1)).toBe(0)
expect(getFreebuffStreakGlmWeeklyUnits(-100)).toBe(0)
// Zero and positive values work as before.
expect(getFreebuffStreakGlmWeeklyUnits(0)).toBe(0)
expect(getFreebuffStreakGlmWeeklyUnits(7)).toBe(1)
expect(getFreebuffStreakGlmWeeklyUnits(14)).toBe(2)
})
})
3 changes: 2 additions & 1 deletion common/src/util/freebuff-streak.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,8 +116,9 @@ export function isFreebuffStreakGlmBonusActive(): boolean {
* The GLM pool resets daily since 2026-07-29 (weekly before), so these units
* refill at that cadence. The name keeps its historical "Weekly". */
export function getFreebuffStreakGlmWeeklyUnits(streak: number): number {
const safeStreak = Math.max(0, streak)
const tiers = Math.min(
Math.floor(streak / FREEBUFF_STREAK_REWARD_INTERVAL_DAYS),
Math.floor(safeStreak / FREEBUFF_STREAK_REWARD_INTERVAL_DAYS),
FREEBUFF_STREAK_REWARD_BONUS_MAX_MULTIPLIER,
)
return tiers * FREEBUFF_STREAK_BONUS_SESSION_UNITS
Expand Down
Loading