feat: add support for tuning alterations - #2838
Open
kulek1 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
AI-authored disclosure (
alphatab-ai-authored-v1)Portions of this content were authored by an AI agent. The agent has read
AGENTS.md and the human submitter accepts responsibility for
compliance with the rules in that document.
Issues
Fixes #2802
Proposed changes
This PR adds optional per-string tuning accidental preferences so alphaTab can preserve and render explicit sharp/flat choices such as
F#andGb.TuningAccidentalMode[]support to the tuning model.Related discussion: alphaTab discussion #2785
Root-cause analysis
Numeric tuning values did not preserve enharmonic spelling, and format-specific sharp/flat metadata was not consistently retained per string.
The renderer also used
Math.max(...labels), allowing malformed GPIF tuning data with a largePitcheslist to exceed the JavaScript argument limit. The fix preserves optional per-string modes and calculates widths iteratively, while retaining legacy behavior by default.Checklist
AI authorship disclosure
(
alphatab-ai-authored-v1) is present at the top of this body, and I havepersonally reviewed every change and can explain each one
Further details