ncry v3: keep response limit out of legacy sessions - #65
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Rationale
MAX_MSG_LENhistorically bounds requests, not legacy responses. Applying it to v1/v2 rejected larger simulator/debug responses and left unread HID fragments queued, cascading into framing errors. The authenticated v3 path retains its strict wire-size limit and terminal failure behavior.An end-to-end v3 overlong-response test is included in Coldcard/firmware#759.
Tests
python -m pytest tests/test_usb_ncry.py -k ncry_v312 passed, 4 deselected.