Skip to content

N°9181 - Fix object class name alignment in summary cards - #1035

Open
steffunky wants to merge 1 commit into
support/3.2from
issue/9181-summary-card-object-alignment
Open

N°9181 - Fix object class name alignment in summary cards#1035
steffunky wants to merge 1 commit into
support/3.2from
issue/9181-summary-card-object-alignment

Conversation

@steffunky

Copy link
Copy Markdown
Member

Base information

Question Answer
Related to a SourceForge thread / Another PR / A GitHub Issue / Combodo ticket? N°9181
Type of change? Bug fix

Symptom (bug) / Objective (enhancement)

When a non admin user hover a link and a summary card appears, the object class name is not aligned properly

image

Reproduction procedure (bug)

  1. On iTop 3.2.3
  2. Create a support agent user and log in with this new user
  3. Hover a UserRequest link
  4. Finally, see that UserRequest class name is not aligned properly

Proposed solution (bug and enhancement)

Add an html tag to ensure the element inherits the same rules as the two parenthesis

Checklist before requesting a review

  • I have performed a self-review of my code
  • I have tested all changes I made on an iTop instance
  • I have added a unit test, otherwise I have explained why I couldn't
  • Is the PR clear and detailed enough so anyone can understand without digging in the code?

Copilot AI balanced review requested due to automatic review settings September 1, 2026 13:17
@steffunky steffunky self-assigned this Sep 1, 2026
@steffunky steffunky added this to the 3.2.4 milestone Sep 1, 2026
@steffunky steffunky added bug Something isn't working UI internal Work made by Combodo labels Sep 1, 2026
@greptile-apps

greptile-apps Bot commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR corrects object class label alignment in object summary cards, particularly for non-admin users.

  • Adds a shared label class to the datamodel link shown to authorized users.
  • Wraps the plain class label in a span so both conditional branches produce an equivalent child element within the inline-flex container.

Confidence Score: 5/5

The PR appears safe to merge, with no actionable correctness, security, or compatibility issues identified.

The markup change preserves the existing label content and link behavior while giving both permission branches a concrete child element that can align consistently with the parent container’s pseudo-elements.

Important Files Changed

Filename Overview
templates/base/layouts/object/object-details/layout.html.twig Normalizes the class-label markup across permission branches so the label participates consistently in the object-class flex layout.

Reviews (1): Last reviewed commit: "N°9181 - Fix object class alignment in s..." | Re-trigger Greptile

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Wraps non-admin object class labels to correct summary-card alignment.

Changes:

  • Adds a consistent label element for linked and plain class names.
  • Ensures flexbox treats the class label consistently with its parentheses.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working internal Work made by Combodo UI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants