ci: add concurrency guard to gh-combined-tasks cron to stop overlapping runs - #214
Draft
claude[bot] wants to merge 1 commit into
Draft
claude[bot] wants to merge 1 commit into
claude[bot] wants to merge 1 commit into
Conversation
…ng runs The workflow has no concurrency guard, so a run stuck on GitHub API rate limits that hits the 10-minute step timeout doesn't stop the next 5-minute cron tick from firing anyway, piling more requests onto the same token and compounding the rate-limit exhaustion (40+ consecutive failed runs). Cancelling in-progress runs on a new trigger gives the token a chance to recover between attempts. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01A789tEwmh3vdssEf47CPZf
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Important Review skippedBot user detected. To trigger a single review, invoke the ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested via Slack thread
Before:
gh-combined-tasks.yaml(the cron running 14 GitHub-polling tasks, including the #frontend release notifier) has noconcurrencyguard. When a run gets stuck on GitHub API rate limits and hits the 10-minute step timeout, the next 5-minute cron tick fires anyway and piles more requests onto the same token — compounding the rate-limit exhaustion instead of letting it recover. This has caused 40+ consecutive failed runs.After: a
concurrencygroup withcancel-in-progress: truemeans a new run cancels any still-running previous one instead of stacking on top of it, so the token gets a chance to recover between attempts.This does not fix the underlying rate-limit exhaustion itself (that needs someone with token access to check
gh api rate_limitand possibly reduce polling frequency or split up the 14 bundled tasks) — it just stops the pile-up that's making it worse.