refactor(website): normalize keys for nested translation catalogs - #18012
Open
benceruleanlu wants to merge 1 commit into
Open
benceruleanlu wants to merge 1 commit into
benceruleanlu wants to merge 1 commit into
Conversation
Eleven website translation keys were both a message and the parent of other messages (learning.categories.all next to learning.categories.all.blurb), which a nested catalog cannot express. Give each such leaf its own segment (label, text or message) and update the consumers, and add a test that keeps the key set prefix-free so the catalogs can take the same nested shape as the app's.
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (7)
Included review availability: Your plan provides up to 8 included reviews per hour; 5 remain after this review. 📝 WalkthroughWalkthroughThe change renames translation keys with explicit suffixes, updates their consumers, and adds a test that detects translation-key prefix collisions. ChangesTranslation key consistency
Priority: ➖ Normal Estimated code review effort: 2 (Simple) | ~10 minutes Change: Refactor Suggested reviewers: Merge Risk: ⚪ Minimal · up to The renamed translations and updated visible consumers are consistent, with no identified merge-blocking behavior change. 🚥 Pre-merge checks | ✅ 7✅ Passed checks (7 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
Contributor
🌐 Website E2ETip All tests passed.
🔗 Website PreviewWebsite Preview: https://comfy-website-preview-pr-18012.vercel.app Models is built and gated by PostHog (workshop-enabled), using staging Cloud. This commit: https://website-frontend-7bgozjb1b-comfyui.vercel.app Last updated: 2026-09-18T06:46:57Z for |
benceruleanlu
added this pull request to stack #18014
September 18, 2026 06:45
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## bl/pr17244-02-locale-policy #18012 +/- ##
============================================================
Coverage 82.74% 82.74%
============================================================
Files 2900 2900
Lines 143707 143707
Branches 36972 36972
============================================================
Hits 118909 118909
Misses 23577 23577
Partials 1221 1221
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
github-actions
Bot
added
the
risk:high
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Normalize eleven website translation keys so messages can move into nested JSON catalogs.
Changes
Review Focus
Key prefixes must not be both a leaf and an object. Foundation 3/18, prerequisite for the catalog migration.
Validation: Independent context-free review verified all 2,887 messages and consumers at 95a6df3; no actionable findings.
Part of the #17244 localization stack and FE-2045 foundation convergence. Local peer review is not a GitHub approval.