Skip to content

i18n: localize English comments inside code samples (zh/ja/ko) - #1711

Merged
comfyui-wiki merged 1 commit into
Comfy-Org:mainfrom
lin-bot23:i18n/localize-code-comments
Sep 18, 2026
Merged

comfyui-wiki merged 1 commit into
Comfy-Org:mainfrom
lin-bot23:i18n/localize-code-comments

Conversation

@lin-bot23

Copy link
Copy Markdown
Contributor

Summary

zh/, ja/ and ko/ pages often ship with English comments inside their code samples, even though the surrounding prose is translated. Comments are documentation the reader is meant to understand, so they are localized here. The rule this follows is the one introduced in #1709: code lines stay byte-for-byte identical, documentation text inside a block is translated.

This PR contains comment text only. Every changed file was verified with a comment-stripped signature comparison against the previous revision, so no code line, indentation, fence or blank line changed (line counts are identical, and heading and fence counts match exactly).

Scope

Language Files with comments localized
zh 32
ja 14
ko 9

Roughly 270 comment lines were translated across those files. Comments that are commands, paths, URLs, parameter names or placeholders (# pip install websocket-client, # browse, # full metadata, # ...) were intentionally left in English, since translating them would be wrong or useless.

What was NOT changed

  • no code lines, string literals or docstrings were touched
  • no prose outside code blocks
  • pnpm translate:sync-hash reports everything already in sync, so no hash churn

Verification

  • comment-stripped code signature compared against the previous revision for every file: 0 diffs in code lines
  • heading counts, fence counts and total line counts unchanged in every file
  • pnpm translate:check-truncation shows the same pre-existing list as main (this PR adds nothing to it)

Files

55 files under zh/, ja/ and ko/ (comments only).

Checklist

  • Code lines verified unchanged
  • Comments localized, technical comments deliberately kept in English
  • No hash or structure churn

Code comments are documentation the reader is meant to understand, so the
zh/ja/ko pages no longer leave them in English. This follows the rule set in
Comfy-Org#1709: code lines stay byte-for-byte identical while documentation text inside a
fenced block is translated.

Comment text only. Every file was checked with a comment-stripped signature
against the previous revision, so no code line, string literal, indentation,
fence or blank line changed; heading, fence and total line counts are identical.
Comments that are commands, paths, URLs or parameter names stay in English.
@coderabbitai

coderabbitai Bot commented Sep 18, 2026

Copy link
Copy Markdown

Review Change StackReview Change Stack

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Advanced

Run ID: 04be43e5-3129-48c2-8160-f09e4bf513d9

📥 Commits

Reviewing files that changed from the base of the PR and between 22b4314 and 6c21565.

📒 Files selected for processing (55)
  • ja/custom-nodes/i18n.mdx
  • ja/development/api-development/sdks.mdx
  • ja/development/comfyui-server/comms_routes.mdx
  • ja/installation/update_comfyui.mdx
  • ja/manager/install.mdx
  • ja/registry/publishing.mdx
  • ja/troubleshooting/overview.mdx
  • ko/agent-tools/mcp.mdx
  • ko/comfy-cli/getting-started.mdx
  • ko/custom-nodes/v3_migration.mdx
  • ko/development/api-development/sdks.mdx
  • ko/development/comfyui-server/api-key-integration.mdx
  • ko/development/comfyui-server/comms_overview.mdx
  • ko/development/comfyui-server/startup-flags.mdx
  • zh/agent-tools/mcp.mdx
  • zh/built-in-nodes/partner-node/image/bfl/flux-1-1-pro-ultra-image.mdx
  • zh/built-in-nodes/partner-node/image/ideogram/ideogram-v1.mdx
  • zh/built-in-nodes/partner-node/image/ideogram/ideogram-v2.mdx
  • zh/built-in-nodes/partner-node/image/luma/luma-image-to-image.mdx
  • zh/built-in-nodes/partner-node/image/luma/luma-reference.mdx
  • zh/built-in-nodes/partner-node/image/luma/luma-text-to-image.mdx
  • zh/built-in-nodes/partner-node/image/openai/openai-dalle2.mdx
  • zh/built-in-nodes/partner-node/image/openai/openai-dalle3.mdx
  • zh/built-in-nodes/partner-node/image/openai/openai-gpt-image1.mdx
  • zh/built-in-nodes/partner-node/image/recraft/recraft-color-rgb.mdx
  • zh/built-in-nodes/partner-node/image/recraft/recraft-controls.mdx
  • zh/built-in-nodes/partner-node/image/recraft/recraft-creative-upscale.mdx
  • zh/built-in-nodes/partner-node/image/recraft/recraft-crisp-upscale.mdx
  • zh/built-in-nodes/partner-node/image/recraft/recraft-image-inpainting.mdx
  • zh/built-in-nodes/partner-node/image/recraft/recraft-image-to-image.mdx
  • zh/built-in-nodes/partner-node/image/recraft/recraft-remove-background.mdx
  • zh/built-in-nodes/partner-node/image/recraft/recraft-replace-background.mdx
  • zh/built-in-nodes/partner-node/image/recraft/recraft-style-realistic-image.mdx
  • zh/built-in-nodes/partner-node/image/recraft/recraft-text-to-image.mdx
  • zh/built-in-nodes/partner-node/image/recraft/recraft-text-to-vector.mdx
  • zh/built-in-nodes/partner-node/image/recraft/recraft-vectorize-image.mdx
  • zh/built-in-nodes/partner-node/image/recraft/save-svg.mdx
  • zh/built-in-nodes/partner-node/video/google/google-veo2-video.mdx
  • zh/built-in-nodes/partner-node/video/luma/luma-concepts.mdx
  • zh/built-in-nodes/partner-node/video/luma/luma-image-to-video.mdx
  • zh/built-in-nodes/partner-node/video/luma/luma-text-to-video.mdx
  • zh/built-in-nodes/partner-node/video/minimax/minimax-text-to-video.mdx
  • zh/built-in-nodes/partner-node/video/pika/pika-image-to-video.mdx
  • zh/built-in-nodes/partner-node/video/pika/pika-scenes.mdx
  • zh/built-in-nodes/partner-node/video/pixverse/pixverse-template.mdx
  • zh/built-in-nodes/partner-node/video/pixverse/pixverse-text-to-video.mdx
  • zh/built-in-nodes/partner-node/video/pixverse/pixverse-transition-video.mdx
  • zh/comfy-cli/getting-started.mdx
  • zh/custom-nodes/backend/lazy_evaluation.mdx
  • zh/custom-nodes/backend/snippets.mdx
  • zh/custom-nodes/i18n.mdx
  • zh/custom-nodes/v3_migration.mdx
  • zh/development/api-development/sdks.mdx
  • zh/development/comfyui-server/comms_routes.mdx
  • zh/registry/publishing.mdx
 _____________________________________________________________________________
< If you can't handle me at my v0.0.1, then you don't deserve me at my v1.0.0 >
 -----------------------------------------------------------------------------
  \
   \   \
        \ /\
        ( )
      .( o ).
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR
✨ Simplify code
  • Create a new PR

Comment @coderabbitai help to get the list of available commands.

@coderabbitai
coderabbitai Bot requested a review from comfyui-wiki September 18, 2026 10:05
@lin-bot23

Copy link
Copy Markdown
Contributor Author

Folding this into #1708 instead of keeping a second i18n PR: the comment localization is now commit 5a1eb90 on the docs/router-translation-sync-2 branch (same 55 files, comment-only, +213/-213). Keeping one open translation PR avoids two PRs touching the same files. Closing this one.

@lin-bot23 lin-bot23 closed this Sep 18, 2026
@lin-bot23 lin-bot23 reopened this Sep 18, 2026
@lin-bot23

Copy link
Copy Markdown
Contributor Author

Reopening: this stays a separate PR. The changes were briefly folded into #1708, but script-driven fixes and translation content should be reviewed separately, so the comment localization lives here on its own branch.

@comfyui-wiki
comfyui-wiki merged commit 249aa87 into Comfy-Org:main Sep 18, 2026
15 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants