Skip to content

chore(ko): align built-in node page names with the English source casing - #1714

Merged
comfyui-wiki merged 1 commit into
Comfy-Org:mainfrom
lin-bot23:chore/ko-page-name-casing
Sep 18, 2026
Merged

comfyui-wiki merged 1 commit into
Comfy-Org:mainfrom
lin-bot23:chore/ko-page-name-casing

Conversation

@lin-bot23

Copy link
Copy Markdown
Contributor

Summary

Twelve ko/built-in-nodes/ pages were named with different casing than their English sources, so tooling that matches translations to sources by path (including the sync pipeline) treated them as orphans with no English page:

Korean page (before) English source
ClipAttentionMultiply.mdx CLIPAttentionMultiply.mdx
ClipMergeAdd.mdx CLIPMergeAdd.mdx
ClipMergeSubtract.mdx CLIPMergeSubtract.mdx
ClipTextEncodeControlnet.mdx CLIPTextEncodeControlnet.mdx
ClipTextEncodeHiDream.mdx CLIPTextEncodeHiDream.mdx
ClipTextEncodeKandinsky5.mdx CLIPTextEncodeKandinsky5.mdx
ClipTextEncodeLumina2.mdx CLIPTextEncodeLumina2.mdx
ClipTextEncodePixArtAlpha.mdx CLIPTextEncodePixArtAlpha.mdx
ClipTextEncodeSD3.mdx CLIPTextEncodeSD3.mdx
ClipTextEncodeHunyuanDiT.mdx ClipTextEncodeHunyuanDit.mdx
ClipTextEncodeSDXL.mdx ClipTextEncodeSdxl.mdx
ClipTextEncodeSDXLRefiner.mdx ClipTextEncodeSdxlRefiner.mdx

Rename-only change. The 12 matching docs.json navigation entries are updated to the new paths; page content, anchors and translationFrom frontmatter are untouched.

The Korean pages stayed reachable before this change because the navigation matched the file names, so this is a consistency fix rather than a broken-page fix. On a case-insensitive filesystem (macOS) the mismatch is invisible locally, which is how it survived.

Verification

  • 12 renames registered by git as pure renames, docs.json re-parses
  • no navigation entry points at a missing page, and no file in the repository still references the old paths
  • validate-links.py --check passes over all 6770 documentation files

Twelve ko/built-in-nodes pages used a different casing than their English
sources (ClipTextEncodeSDXL vs ClipTextEncodeSdxl, ClipMergeAdd vs CLIPMergeAdd,
and so on), which made tooling that maps translations by path treat them as
files without an English source. Renamed to match English; the twelve matching
docs.json navigation entries follow. Rename-only, page content untouched.
@coderabbitai

coderabbitai Bot commented Sep 18, 2026

Copy link
Copy Markdown

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Advanced

Run ID: f5e3e815-f1ad-42fe-b124-9ae6289bded9

📥 Commits

Reviewing files that changed from the base of the PR and between 26f1ff6 and c09c79e.

📒 Files selected for processing (13)
  • docs.json
  • ko/built-in-nodes/CLIPAttentionMultiply.mdx
  • ko/built-in-nodes/CLIPMergeAdd.mdx
  • ko/built-in-nodes/CLIPMergeSubtract.mdx
  • ko/built-in-nodes/CLIPTextEncodeControlnet.mdx
  • ko/built-in-nodes/CLIPTextEncodeHiDream.mdx
  • ko/built-in-nodes/CLIPTextEncodeKandinsky5.mdx
  • ko/built-in-nodes/CLIPTextEncodeLumina2.mdx
  • ko/built-in-nodes/CLIPTextEncodePixArtAlpha.mdx
  • ko/built-in-nodes/CLIPTextEncodeSD3.mdx
  • ko/built-in-nodes/ClipTextEncodeHunyuanDit.mdx
  • ko/built-in-nodes/ClipTextEncodeSdxl.mdx
  • ko/built-in-nodes/ClipTextEncodeSdxlRefiner.mdx

Included review availability: Your plan provides up to 2 included reviews per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

The Korean documentation navigation updates nine groups of built-in node page slugs. The changes apply CLIP capitalization and normalize selected SDXL and DiT suffix casing. Unchanged neighboring slugs remain unchanged.

Changes

Korean documentation navigation

Layer / File(s) Summary
Built-in node page slug updates
docs.json
Updates selected Korean navigation slugs for CLIP attention, text encoding, ControlNet, merge, Stable Diffusion, and Hunyuan pages. Existing neighboring entries remain unchanged.

Suggested reviewers: comfyui-wiki

Priority: ⬇️ Low

Merge Risk: ⚪ Minimal · up to c09c7

The documentation navigation casing updates are mergeable with no identified broken links or unresolved consistency risk.

🚥 Pre-merge checks | ✅ 2
✅ Passed checks (2 passed)
Check name Status Explanation
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR
✨ Simplify code
  • Create a new PR

Comment @coderabbitai help to get the list of available commands.

@coderabbitai
coderabbitai Bot requested a review from comfyui-wiki September 18, 2026 11:18
@comfyui-wiki
comfyui-wiki merged commit 6797631 into Comfy-Org:main Sep 18, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants