Skip to content

cursorrules: align output-name policy with the ComfyUI frontend - #146

Merged
comfyui-wiki merged 1 commit into
Comfy-Org:mainfrom
lin-bot23:remove-output-english-rule
Sep 14, 2026
Merged

comfyui-wiki merged 1 commit into
Comfy-Org:mainfrom
lin-bot23:remove-output-english-rule

Conversation

@lin-bot23

Copy link
Copy Markdown
Contributor

Summary

Replaces the blanket "output names stay English" rule with a frontend-first policy.

Why

The ComfyUI frontend itself localizes output names per locale. Evidence from the frontend translation export (docs-generation/data/node_translations.json):

Node zh frontend es frontend
HunyuanVideo15SuperResolution 正面条件 / 负面条件 / Latent positivo / negativo / latente
TripoImageToModelNodeV2 模型 task_id / GLB / FBX task_id del modelo / GLB / FBX
TripoSmartSegmentNode 分割 task_id / part_names / parts / mask task_id de segmentación / part_names / parts / mask

So "output names are programmatic identifiers" is only true for technical identifiers (task_id, GLB, part_names, parts, mask, FBX). Semantic outputs (positive/negative-style) are localized in the UI, and docs should match what users actually see.

Recent translation runs had aligned docs to the frontend; PR review applying the old English-only rule reverted that alignment, de-syncing docs from the UI.

New policy

Mirror the frontend exactly, per output, per language, using node_translations.json (outputs.<index>.name) as the source of truth. Outputs without a frontend entry keep the English name. Data types stay English (unchanged).

The old rule forced English output names in all localized Outputs tables,
but the ComfyUI frontend itself localizes semantic output names per locale
(zh: 正面条件/负面条件, es: positivo/negativo) while keeping technical
identifiers English (task_id, GLB, part_names, mask).

New policy: mirror the frontend exactly, per output, per language, using
docs-generation/data/node_translations.json (outputs.<index>.name) as the
source of truth. Outputs without a frontend entry keep the English name.

Motivated by PR Comfy-Org#145 review friction: the drift-repair retranslation had
aligned docs to the frontend, and a reviewer applying the old rule
reverted that alignment, de-syncing docs from what users see in the UI.
@coderabbitai

coderabbitai Bot commented Sep 13, 2026

Copy link
Copy Markdown

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Advanced

Run ID: 831dbcbb-7953-444c-b132-75d8568324d3

📥 Commits

Reviewing files that changed from the base of the PR and between f45385c and 0b8d441.

📒 Files selected for processing (1)
  • .cursorrules

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

The output naming rule now follows ComfyUI frontend translations by language. Semantic outputs can be localized, while technical identifiers remain in English. English remains the fallback when no translation exists.

Changes

Output localization guidance

Layer / File(s) Summary
Update output naming rule
.cursorrules
The rule now uses docs-generation/data/node_translations.json frontend translations for semantic output names. Technical identifiers remain in English, with English as the fallback.

Priority: ⬇️ Low

Merge Risk: ⚪ Minimal · up to 0b8d4

This guidance update aligns output naming with frontend translations and introduces no established production risk.

🚥 Pre-merge checks | ✅ 2
✅ Passed checks (2 passed)
Check name Status Explanation
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
✨ Simplify code
  • Create PR with simplified code

Comment @coderabbitai help to get the list of available commands.

@comfyui-wiki
comfyui-wiki merged commit bddd2b3 into Comfy-Org:main Sep 14, 2026
4 checks passed
@github-actions github-actions Bot locked and limited conversation to collaborators Sep 14, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants