Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
❌ Upload JSON generation failed |
🔤 Spellcheck Results
|
PyPI quota check (version bump PR)PyPI enforces about 10 GB total storage per project (all releases). Per-file upload limit is about 100 MB. PyPI project quota (cumulative storage)
Quota thresholds: 🟡 ≥80% · 🔴 ≥90% · ⛔ ≥95% Local bundle size (estimated next wheel/sdist)
Local thresholds: 🟡 ≥85 MB · 🔴 ≥95 MB Add future extension packages under ComfyUI reference (safe to delete vs keep)Versions referenced = ever pinned in ComfyUI requirements.txt via
Total reclaimable (orphan versions): 1.34 GB Per-package orphan version lists (click to expand)Orphan versions —
|
Release distribution summary (version bump PR)Meta version: Catalog summary
Templates changed in this PR
Full cloud-only template list
Full custom-nodes (pip excluded) template list
Pip exclusion follows |
## Summary New users now open the Popular template collection instead of the outdated Getting Started collection. The paired catalog change also archives Node Basics so neither outdated learning collection remains in the picker. ## Changes - **What**: Default first-run template navigation to Popular and initialize its matching sort immediately. - **Catalog**: Getting Started is already archived by [workflow_templates PR Comfy-Org#1088](Comfy-Org/workflow_templates#1088); the paired catalog PR archives Node Basics while preserving the source workflows and shared assets. - **Tests**: Update the existing composable test and template-picker Playwright coverage. ## Review Focus - The default changes only for users without a previously selected template category. - The immediate nav/sort coordination prevents Popular content from initially using the default sort. Linear: https://linear.app/comfyorg/issue/GTM-422/archive-getting-started-and-node-basics-templates-redirect-to-popular Paired catalog PR: Comfy-Org/workflow_templates#1097 --------- Co-authored-by: Maanil Verma <vermaMaanil97@gmail.com>
Summary
Completes the catalog side of GTM-422 by archiving the seven remaining Node Basics templates. Getting Started was already archived on
mainby #1088, so this PR does not repeat that work.Paired frontend PR: Comfy-Org/ComfyUI_frontend#14896
Changes
archived/.input/andoutput/assets in place;workflow_template_input_files.jsonremains unchanged with 639 assets.0.11.32to0.11.33so the catalog change can be published. Frozen legacy media package versions are unchanged.Rollout
Both Cloud and Desktop need to consume this update:
comfyui-workflow-templates==0.11.33to PyPI, then update the exactcomfyui-workflow-templatespin in the ComfyUI repository to the published version. This pin update is a follow-up and is not part of this two-PR change.This PR needs the
releaselabel for the repository's release automation.Validation
scripts/validate/validate_templates.pyscripts/validate/validate_manifests.py— no errors; 80 pre-existing unreferenced-template warningsscripts/ci/check_frozen_policy.py --base-ref origin/main