Conversation
…fault prompt The api_seedance2_5_flf2v template shipped with an internal message baked in as the default prompt on the ByteDance2FirstLastFrameNode, so it was visible to anyone opening the template. Replace it with a generic cinematic prompt that describes the bundled pool start/end frames (empty pool -> packed pool party), matching the style of the sibling Seedance FLF2V templates and the template's own index.json description. Regenerate packages/core manifest.json for the new asset SHA256. Fixes PN-825
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
No findings to address here — CodeRabbit skipped the review because the PR is a draft, which is intentional on my side (our agent workflow opens PRs as drafts for a human to promote). No code changes were made in response. Triggering a scan anyway so the change still gets covered before anyone promotes it, since this one is gating the prod template merge. For reviewer context, the diff is two lines:
Already verified: @coderabbitai review |
🔤 Spellcheck Results
|
|
Thanks for the review @synap5e. The approval came through with no comment body or inline comments, so I read it as a straight approve — no changes made, branch is still at the reviewed commit CI on that commit for the record:
Left as a draft per our agent workflow — ready for a maintainer to promote and merge whenever. Since this one is gating the prod template merge, no need to wait on me. |
|
This looks superseded: #1106 landed the same fix on 2026-08-08 and main's flf2v default prompt no longer carries the internal text. That is also where the conflict here comes from, since both PRs rewrite the same widget value. Suggest closing unless there is something in this version worth keeping over what merged. |
PR Created by the Glary-Bot Agent
Problem
The
api_seedance2_5_flf2vtemplate ("Seedance 2.5: FLF2V") shipped with an internal message baked in as the defaultpromptvalue on theByteDance2FirstLastFrameNode:Anyone opening the default template in ComfyUI saw this text in the node UI. Introduced in #1101 (
Wan Animate 2 and Seedance2.5 templates).Fixes PN-825 — https://linear.app/comfyorg/issue/PN-825
Fix
Replaced the leaked text with a generic cinematic prompt. The replacement describes the transition actually shown by the template's own bundled assets (
pool_start_frame.png→pool_end_frame.png: an aerial wide of an empty resort pool ringed by a crowd → an overhead close-up of that pool packed with partiers), which also matches the "empty-to-packed" example called out in this template'sindex.jsondescription:The style follows the sibling FLF2V templates (
api_seedance2_0_flf2v,api_bytedance_seedance1_5_flf2v), which use the same "first frame: … last frame: …" camera-move phrasing.packages/core/.../manifest.jsonis regenerated (npm run sync:bundles) for the new asset SHA256 — required, orvalidate:manifestsfails.Scope
Two lines, one string value. No other widget values changed — verified in a live graph that every widget still maps to its original value (
720p, duration5,generate_audiotrue,mp4, seed0,randomize, watermark false, empty asset ids), so nowidgets_valuesarray shift.Grepped every repo in the workspace for the leaked string — this template JSON was the only source occurrence. The copy under
packages/json/.../templates/is gitignored and build-generated; it regenerates correctly from this change.Verification
npm run validate:templates— ✅ all validations passednpm run validate:manifests— ✅ no errors (82 pre-existing unrelated warnings about unreferenced template files)pytest packages/core/tests— ✅ 38 passedMarkdownNote/Notenodes andindex.jsontitle/description; confirmed viaextract_workflow_text.pythat this prompt is not in the spellcheck corpus--cpu) + frontend dev server, confirmed the backend serves the corrected prompt from/templates/api_seedance2_5_flf2v.json, then loaded the template into a real graph and inspected the nodeThe screenshot below is the same node from the bug report, now showing a normal prompt, with both input frames loading and no errors.
Screenshots